-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable HID support by default in GhostBSD #207
Conversation
Added uhid, hid, and hidraw modules to be loaded by default via sysrc. This ensures better compatibility with USB HID devices for GhostBSD users.
Reviewer's Guide by SourceryThis pull request enables USB HID support by default in GhostBSD by loading the Sequence diagram for GhostBSD boot process with HID module loadingsequenceDiagram
participant Boot as System Boot
participant RC as RC System
participant KM as Kernel Module Loader
participant HID as HID Modules
participant USB as USB Devices
Boot->>RC: Start system
RC->>KM: Load kernel modules
KM->>HID: Load uhid.ko
KM->>HID: Load hid.ko
KM->>HID: Load hidraw.ko
HID->>USB: Enable HID device support
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vimanuelt - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
chroot ${release} sysrc avahi_dnsconfd_enable="YES" | ||
chroot ${release} sysrc ntpd_enable="YES" | ||
chroot ${release} sysrc ntpd_sync_on_start="YES" | ||
chroot ${release} sysrc uhid_load="YES" | ||
chroot ${release} sysrc hid_load="YES" | ||
chroot ${release} sysrc hidraw_load="YES" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider using kld_list to load all HID-related modules in a single sysrc call
Instead of separate sysrc calls for each module, you could use: chroot ${release} sysrc kld_list+="hid uhid hidraw". This is more maintainable and slightly more efficient during boot.
chroot ${release} sysrc avahi_dnsconfd_enable="YES" | |
chroot ${release} sysrc ntpd_enable="YES" | |
chroot ${release} sysrc ntpd_sync_on_start="YES" | |
chroot ${release} sysrc uhid_load="YES" | |
chroot ${release} sysrc hid_load="YES" | |
chroot ${release} sysrc hidraw_load="YES" | |
chroot ${release} sysrc avahi_dnsconfd_enable="YES" | |
chroot ${release} sysrc ntpd_enable="YES" | |
chroot ${release} sysrc ntpd_sync_on_start="YES" | |
chroot ${release} sysrc kld_list+="hid uhid hidraw" |
Alex let me know this is an incorrect procedure. Will cancel and submit at a later time. |
Added uhid, hid, and hidraw modules to be loaded by default via sysrc.
This ensures better compatibility with USB HID devices for GhostBSD users.
Summary by Sourcery
Build:
uhid
,hid
, andhidraw
kernel modules in the base system configuration.