Skip to content

Fix fetch_x_drivers_packages grep #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix fetch_x_drivers_packages grep #195

merged 1 commit into from
Jul 3, 2024

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Jul 3, 2024

The grep was getting the /latest and base URL.

Summary by Sourcery

This pull request fixes an issue in the fetch_x_drivers_packages function where the grep command was incorrectly matching URLs, causing it to capture both the base URL and the '/latest' URL. The updated grep pattern now correctly matches the '/latest' URL for both stable and unstable builds.

  • Bug Fixes:
    • Corrected the grep pattern in fetch_x_drivers_packages to accurately match the '/latest' URL for both stable and unstable builds.

@ericbsd ericbsd self-assigned this Jul 3, 2024
@ericbsd ericbsd requested review from a team as code owners July 3, 2024 22:02
Copy link
Contributor

sourcery-ai bot commented Jul 3, 2024

Reviewer's Guide by Sourcery

This pull request fixes the fetch_x_drivers_packages function in the build.sh script to ensure that the correct package URLs are fetched. The previous implementation was incorrectly capturing both the base URL and the '/latest' URL, which has now been corrected to specifically target URLs ending with '/latest'.

File-Level Changes

Files Changes
build.sh Updated the grep command in the fetch_x_drivers_packages function to ensure it captures the correct package URLs ending with '/latest'.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ericbsd ericbsd merged commit e044ef8 into master Jul 3, 2024
2 checks passed
@ericbsd ericbsd deleted the fix-x-grep branch July 3, 2024 22:05
@ericbsd ericbsd added the bug label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant