Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding multiple space-separated classes for openClass #382

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow adding multiple space-separated classes for openClass #382

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7e9e58
Allow adding multiple space-separated classes for `openClass`
liamtarpey Oct 21, 2020
d1dc769
Trim end of string as breaks if extra space
liamtarpey Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,10 @@ const MicroModal = (() => {
}

showModal (event = null) {
const openClass = this.config.openClass.trim().split(' ')
this.activeElement = document.activeElement
this.modal.setAttribute('aria-hidden', 'false')
this.modal.classList.add(this.config.openClass)
this.modal.classList.add(...openClass)
this.scrollBehaviour('disable')
this.addEventListeners()

Expand All @@ -85,14 +86,14 @@ const MicroModal = (() => {
}
this.config.onClose(this.modal, this.activeElement, event)

let openClass = this.config.openClass.trim().split(' ') // <- old school ftw
if (this.config.awaitCloseAnimation) {
let openClass = this.config.openClass // <- old school ftw
this.modal.addEventListener('animationend', function handler () {
modal.classList.remove(openClass)
modal.classList.remove(...openClass)
modal.removeEventListener('animationend', handler, false)
}, false)
} else {
modal.classList.remove(this.config.openClass)
modal.classList.remove(...openClass)
}
}

Expand Down