Fix issues with JS backend syntax translation #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed some issues with the JS backend syntax translation introduced by ghcjs#135.
This was referenced May 3, 2024
|
Changes to miso: dmjio/miso#740. |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to make these changes to get the miso examples which depend on ghcjs-base (xhr, file-reader, canvas2d) working. There may be more issues introduced by #135, but I don't have test cases for those atm.
I will do a more thorough review if you feel I'm on the right track. This is my first time modifying JS FFI code.
I also needed to make some changes to miso itself, which I will be submitting PRS for soon.
Thanks for your work on the Javascript backend! ❤️