Do not interfer with system umask. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why would you want to tamper your daemon umask (especially for 0000, which is world-writable‽)
I am using your daemons' fork to run delayed_job with delayed_paperclip (uploaded assets management). Why would I want my assets to be world-writtable ?
I know this is not from your patches, but original daemons' one. However, since your fork is the one recommended to run delayed_jobs and being able to restart/stop daemons, I think it would be a good idea to put it into your code base. daemons' upstream (incompatible with delayed_job) had already patched their code with an equivalent modification.