gguf-py: Make sentencepiece optional #14200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahajha
changed the title
|
Are there alternatives to sentencepiece? If it is no longer maintained, it will always be broken. (I met this issue since Python 3.13) |
|
Not that I'm aware of, but I'm not that knowledgeable about these things. I'm coming at this from a pure packaging perspective. |
compilade
approved these changes
Jun 18, 2025
compilade
reviewed
Jun 18, 2025
Co-authored-by: compilade <[email protected]>
CISC
approved these changes
Jun 18, 2025
modularbot
pushed a commit
to modular/modular
that referenced
this pull request
Jun 20, 2025
ggml-org/llama.cpp#14200 mlc-ai/xgrammar#337 gguf immediately released a new version, waiting on xgrammar. In the meantime though, bump gguf and remove the explicit sentencepiece dependency, it isn't used anywhere. This should automatically propagate up towards users, no need to bump minimum required versions. MODULAR_ORIG_COMMIT_REV_ID: 27aa8a6ece6f56d253875294f8ae9988eecc8cc1
gabe-l-hart
added a commit
to gabe-l-hart/llama.cpp
that referenced
this pull request
Jun 20, 2025
* mamba2-sync: (24 commits) sync : ggml Add `ggml_roll` (ggml/1274) docs : fix the link to llama.h (ggml-org#14293) CUDA: add conv_2d_transpose (ggml-org#14287) lint : remove trailing whitepace (ggml-org#14304) vocab : prevent tokenizer overflow (ggml-org#14301) sycl: add usage of enqueue_functions extension (ggml-org#14244) Implement GGML_CPU_ALL_VARIANTS for PowerPC (ggml-org#14286) llama : improve sep token handling (ggml-org#14272) cuda : synchronize graph capture and cublas handle destruction (ggml-org#14288) ggml : fix repack work size for mul_mat_id (ggml-org#14292) ggml: Update KleidiAI to v1.9.0 (ggml-org#14277) model : more uniform output id handling (ggml-org#14275) ubatch : new splitting logic (ggml-org#14217) CUDA: add conv_2d_dw (ggml-org#14265) ggml-cpu : remove unnecesary arm feature detection (ggml-org#14281) gguf-py : make sentencepiece optional (ggml-org#14200) server : add server parameters for draft model cache type (ggml-org#13782) build : suppress gcc15 compile warnings (ggml-org#14261) sycl: Cleanup codepaths in Get Rows in sycl backend (ggml-org#14215) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentencepiece has not had a new release in over a year, and users are running into easily fixable install issues like CMake minimum versions, missing headers, and missing wheels for newer python versions. See recent issues: https://github.com/google/sentencepiece/issues, like this one for example: google/sentencepiece#1113
Sentencepiece is only actually used if users are already using it, so it seems pointless to depend on it directly. This updates the support to raise an error if sentencepiece isn't installed.