Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression from "Replace fence with semaphore" #6067

Open
victorb opened this issue Aug 1, 2024 · 0 comments
Open

Performance regression from "Replace fence with semaphore" #6067

victorb opened this issue Aug 1, 2024 · 0 comments

Comments

@victorb
Copy link

victorb commented Aug 1, 2024

Description

When at commit 886dc94f5, running the boids example and clicking inside the window makes nothing happen, as expected. However, if we use the commit after (e5c62fb5b - "vulkan: Replace fence with semaphore when acquiring surfaces (#4967)") and run the same example, now there is noticeable latency for each click.

Originally discovered in a issue in Bevy: bevyengine/bevy#14303

Another user found which wgpu version was affected and which version wasn't: honehone12/bevy_replicon_bootstrap#47

Based on the versions mentioned in bevy_replicon_bootstrap I bisected until arriving at the commit introducing the issue, which is e5c62fb

Repro steps

  • git checkout 886dc94f5

  • cargo +nightly run --bin wgpu-examples boids

  • Observe no lag when clicking

  • git checkout e5c62fb5b (one commit later than 886dc94f5)

  • cargo +nightly run --bin wgpu-examples boids

  • Observe lag when clicking

Expected vs observed behavior

Expected no lag on mouse click, observed lag on mouse click.

Extra materials

Videos demonstrating the issue can be found in the Bevy issue: bevyengine/bevy#14303 (comment)

Platform

So far, seems to only happen on Linux + X11 + Nvidia GPU combo.

Output from wgpu-info

Adapter 0:
                 Backend: Vulkan
                    Name: NVIDIA GeForce RTX 3090 Ti
                VendorID: 0x10DE
                DeviceID: 0x2203
                    Type: DiscreteGpu
                  Driver: NVIDIA
              DriverInfo: 555.58.02
        WebGPU Compliant: true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant