Skip to content

Commit

Permalink
Undo doing less bench iterations under cfg(test) (#6021)
Browse files Browse the repository at this point in the history
  • Loading branch information
Wumpf committed Jul 24, 2024
1 parent 0aca442 commit 9b680e6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
6 changes: 0 additions & 6 deletions benches/benches/computepass.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,14 @@ use rayon::iter::{IntoParallelIterator, ParallelIterator};

use crate::DeviceState;

#[cfg(not(test))]
const DISPATCH_COUNT: usize = 10_000;
#[cfg(test)]
const DISPATCH_COUNT: usize = 8; // Running with up to 8 threads.

// Currently bindless is _much_ slower than with regularly resources,
// since wgpu needs to issues barriers for all resources between each dispatch for all read/write textures & buffers.
// This is in fact so slow that it makes the benchmark unusable when we use the same amount of
// resources as the regular benchmark.
// For details see https://github.com/gfx-rs/wgpu/issues/5766
#[cfg(not(test))]
const DISPATCH_COUNT_BINDLESS: usize = 1_000;
#[cfg(test)]
const DISPATCH_COUNT_BINDLESS: usize = 8; // Running with up to 8 threads.

// Must match the number of textures in the computepass.wgsl shader
const TEXTURES_PER_DISPATCH: usize = 2;
Expand Down
4 changes: 0 additions & 4 deletions benches/benches/renderpass.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ use rayon::iter::{IntoParallelIterator, ParallelIterator};

use crate::DeviceState;

#[cfg(test)]
const DRAW_COUNT: usize = 8; // Running with up to 8 threads.

#[cfg(not(test))]
const DRAW_COUNT: usize = 10_000;

// Must match the number of textures in the renderpass.wgsl shader
Expand Down

0 comments on commit 9b680e6

Please sign in to comment.