Merge #59

59: Fix the zombie error of shader compilation r=grovesNL a=kvark What I think is happening is that the library object keeps a reference to the error, so we shouldn't release it if the library is created. Co-authored-by: Dzmitry Malyshau <[email protected]>
gfx-rs · Jun 30, 2018 · 721def6 · 721def6
2 parents e0c7933 + 6e8e383
commit 721def6
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/device.rs b/src/device.rs
@@ -229,8 +229,8 @@ impl DeviceRef {
                 let desc: *mut Object = msg_send![err, localizedDescription];
                 let compile_error: *const libc::c_char = msg_send![desc, UTF8String];
                 let message = CStr::from_ptr(compile_error).to_string_lossy().into_owned();
-                msg_send![err, release];
                 if library.is_null() {
+                    msg_send![err, release];
                     return Err(message);
                 } else {
                     warn!("Shader warnings: {}", message);