-
Notifications
You must be signed in to change notification settings - Fork 542
Associated resource type preparations #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
84037df
Parameterise Renderer over Device
brendanzab 326bd37
Rename CommandBufferHelper->CommandBufferExt
brendanzab 7d4c9dd
Move Command into gl module
brendanzab 6bd9c2d
Don't re-export opengl command buffer
brendanzab 01f212d
Add associated resource types to Device
brendanzab 6337291
Add resource types to CommandBuffer
brendanzab c25ef1d
Parameterise handles over Device
brendanzab b9ca884
Attempt to use a generic Device for BufferHandle impl
brendanzab 28f69e1
Add temporary fix for rust-lang/rust#22356
brendanzab af64f3e
Add Resources trait for common resource types
brendanzab 349ad7b
Add Sync and Send to resource types
brendanzab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the user has to access
gfx_device_gl
crate anyway in order to create he device, perhaps we could provide a typedef forTextureHandle
in there?