-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce gvltctl local-run
command
#59
Open
aleasims
wants to merge
14
commits into
dev
Choose a base branch
from
feature/run-command
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This subcommand runs VM built with `gvltctl build` locally. Only basic features implementation now.
Use `gvltctl local-run` for VM test run.
0ee7a46
to
fdad67d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
gvltctl local-run
command. This command is used to locally run VM generated bygvltctl build
.This tool is basically a new version of
shim-executor
for Firestarter. It runs VM according to Gevulot-compatible VM specification.Features
task.yaml
file for local and on-chain executionDesign&usage notes
This command is designed to work with both: CLI arguments and task specification from
task.yaml
file. Iftask.yaml
is provided, CLI arguments will overwrite or complete definitions from file.Note: some of the fields from
task.yaml
are always ignored because they make no sense in local execution:spec.resources.gpus
- use--gpu
argument to pass certain PCI devicedspec.resources.time
- currently there is no timeout for local executionspec.outputContexts.retentionPeriod
- makes no sense here--input
/--output
arguments are designed to provide input/output contexts in a more convenient way. Values passed to them are not the same as specified intask.yaml
. Task file is expected to always have a proper URI. Example:--input file.txt:file.txt
is equivalent to this intask.yaml
:Output of the command looks a bit similar to task status, which is used on-chain:
To run
gvltctl local-run
you will needqemu-system-x64_64
available in PATH.You can use remote inputs and VM images, if they are specified in
task.yaml
:They will be downloaded before execution. This makes re-using
task.yaml
easier. However note that no caching is implemented at the moment: each file will be re-downloaded and removed at the end of execution.Examples
CLI only:
The same with
task.yaml
:Usage