Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary build reruns caused by tonic bug #43

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

koxu1996
Copy link
Contributor

@koxu1996 koxu1996 commented Feb 7, 2025

I had hard time using gevulot-rs as dependency, as every change required 5 seconds for intellisense to pick up. This was caused by upstream bug in tonic builder - see Valensas/tonic-buf-build#7.

This PR workarounds it, by disabling all rerun-if-changed emits from tonic builder, and emittitng the valid one manually (hardcoded proto path).

@koxu1996 koxu1996 requested review from trusch and aleasims February 7, 2025 23:11
@koxu1996 koxu1996 self-assigned this Feb 7, 2025
@koxu1996
Copy link
Contributor Author

koxu1996 commented Feb 7, 2025

Subsequent build time - before PR:

$ cargo build
   Compiling gevulot-rs v0.1.3 (/tmp/gevulot-rs)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.88s

Subsequent build time - after PR:

$ cargo build
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.12s

@koxu1996 koxu1996 merged commit 680dfd6 into main Feb 10, 2025
1 check passed
@koxu1996 koxu1996 deleted the bugfix/avoid-tonic-rerun branch February 10, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants