Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have handling for tx failures, after tx is broadcasted with sync mode:
gevulot-rs/src/base_client.rs
Lines 332 to 339 in ad1190d
Sync mode means that basic checks are done (structure, signatures, fees), and tx is added to the mempool. However, execution still can fail later.
Currently we fetch the tx response and blindly start parsing its message - even if tx code is non-zero - which results in
Error: Unknown("no response message")
.This PR improves handling with a dedicated Tx error: hash, code and log included.
For example, instead of "no response message" (like in gevulotnetwork/gvltctl#44), now you will get: