Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: program stopping due to recursion #47

Closed
wants to merge 2 commits into from
Closed

fix: program stopping due to recursion #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78872b8
fix recursion problem
steven-mi Aug 10, 2023
5fc5917
update version
steven-mi Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog db-rocket

## Version 1.3.3

- Fix watch stopping due to maximum recursion

## Version 1.3.2

- Refine prints to be more clear
Expand Down
3 changes: 2 additions & 1 deletion rocket/rocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ def launch(
observer.join()
if watcher.modified_files:
self._deploy(watch=watch, modified_files=watcher.modified_files)
return self.launch(project_location=project_location, dbfs_path=dbfs_path, watch=True, _deploy=False)
return execute_shell_command(
f'rocket launch --project_location={project_location} --watch={True} --dbfs_path={dbfs_path} _deploy=False')

def _build_and_deploy(self, watch, modified_files=None):
self._build()
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

setuptools.setup(
name="databricks-rocket",
version="1.3.2",
version="1.3.3",
author="GetYourGuide",
author_email="[email protected]",
description="Keep your local python scripts installed and in sync with a databricks notebook. Shortens the feedback loop to develop projects using a hybrid enviroment",
Expand Down