Tests and related bugfixes for BaseStore.remove #1165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote unit tests for BaseStore.remove and discovered 2 bugs along the way:
BaseStore.refresh_lookup_cache
method.)removed
signal. (If I am not mistaken, the code never relied on this signal, but let's fix it anyway.)The main changes are as follows:
BaseStore.remove
,removed
signal is emitted for each removed item,SavedSearch
a subclass ofStoreItem
to keep things readable.