Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update Go dependencies #1527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reneleonhardt
Copy link
Contributor

@reneleonhardt reneleonhardt commented Jun 11, 2024

Features

  • Update Go dependencies
  • Release with Go 1.22
  • Update alpine

@reneleonhardt reneleonhardt force-pushed the updates branch 5 times, most recently from 227b53b to 8de8db6 Compare June 12, 2024 18:45
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I think your PR is doing way too many things in one PR that should happen in multiple smaller PRs. Can you please split it up into smaller parts, such as:

  1. Updating Go deps.
  2. Extending CI to build multiple deps.
  3. Updating the release process and using dependabot for updating Dockerfile.
  4. Updating Rust dependencies and using dependabot for updating Cargo.toml.
  5. Updating Makefile.

Thanks!

Makefile Outdated Show resolved Hide resolved
@reneleonhardt reneleonhardt force-pushed the updates branch 2 times, most recently from 14c78b6 to de2a7c0 Compare June 16, 2024 07:18
@felixfontein felixfontein requested a review from a team June 16, 2024 07:23
@reneleonhardt reneleonhardt changed the title chore(deps): Update dependencies chore(deps): Update Go dependencies Jun 16, 2024
@@ -65,7 +65,7 @@ jobs:
id: goreleaser
uses: goreleaser/goreleaser-action@286f3b13b1b49da4ac219696163fb8c1c93e1200 # v6.0.0
with:
version: 1.21.x
version: 1.22.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the Go version BTW, but the goreleaser version.

Ref: #1547 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, this is confusing, why would you use a goreleaser version from Sept 2023 if 1.26.x is the last 1.x? 🤔
I suggest "updating" to 1.26 first, but 2.1 is around the corner...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the last person who updated the version also thought it is a Go version (which it is not). I would avoid updating this at all until we have proper packaging testing (see #1547 for what the update from 1.20.x to 1.21.x caused).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants