Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxwidgets: Update to v3.2.6 #4486

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

wxwidgets: Update to v3.2.6 #4486

wants to merge 30 commits into from

Conversation

androidnisse
Copy link
Contributor

Summary

  • Release notes can be found here.

Test Plan

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged (Write an appropriate message in the Summary section)

@androidnisse androidnisse changed the title Update wxwidgets wxwidgets: Update to v3.2.6 Nov 29, 2024
EbonJaeger
EbonJaeger requested changes Dec 14, 2024
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, could you add monitoring.yml files to both packages?

EbonJaeger
EbonJaeger previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if someone wants to merge it. I don't know that I'll get to it today.

@davidjharder
Copy link
Member

Sadly it seems rebuilds might be a good idea, I can't get codelite to build with new wxwidgets

@EbonJaeger EbonJaeger dismissed their stale review December 16, 2024 23:24

Reported revdep failure to build

@davidjharder
Copy link
Member

You have a conflict with cemu because it was updated in the time since this PR was started. You will have a similar issue with audacity. You will need to rebase

@malfisya
Copy link
Member

Missing monitoring.yml in this PR are already included in my PR. Cheers!

@androidnisse
Copy link
Contributor Author

All should be done except KiCad which I have not enough disk space to build.

malfisya
malfisya reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Please remove "Summary" from the commit message when no message needed

@malfisya malfisya removed their request for review December 19, 2024 23:27
@malfisya
Copy link
Member

I grep the repo and found 3 packages is still missing from the rebuild:

  • 0ad
  • trelby
  • prusa-slicer

malfisya
malfisya requested changes Dec 21, 2024
View reviewed changes
Copy link
Member

@malfisya malfisya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are ABI removal in radiotray-ng and visualboyadvance-m. Can you make sure both of them run normally?

Also as noted in my previous comment, there are still 3 packages missing from the rebuild:

  • 0ad
  • trelby
  • prusa-slicer

packages/r/radiotray-ng/abi_libs Show resolved Hide resolved
packages/r/radiotray-ng/abi_symbols Show resolved Hide resolved
packages/v/visualboyadvance-m/abi_symbols Show resolved Hide resolved
@androidnisse
Copy link
Contributor Author

There are ABI removal in radiotray-ng and visualboyadvance-m. Can you make sure both of them run normally?

Also as noted in my previous comment, there are still 3 packages missing from the rebuild:

* 0ad

* trelby

* prusa-slicer

0ad and prusa-slicer does not build with current recipe. I have opened two issues for them.

androidnisse and others added 22 commits December 22, 2024 13:10
@androidnisse
guayadeque: rebuild for wxwidgets
cde984f
@androidnisse
mediainfo: rebuild for wxwidgets
c14aca1
@androidnisse
codeblocks: rebuild for wxwidgets
0e61096
@androidnisse
amule: rebuild for wxwidgets
6b0b7b7
@androidnisse
radiotray-ng: rebuild for wxwidgets
4f19df1
@androidnisse
poedit: rebuild for wxwidgets
3e136cd
@androidnisse
wxsqlite3: rebuild for wxwidgets
8f06d12
@androidnisse
libfilezilla: Update to v0.49.0
0e7eb44
@androidnisse
filezilla: Update to v3.68.1 and change source
d4fde54
@androidnisse
megaglest: rebuild for wxwidgets
806c5eb
@androidnisse
erlang: rebuild for wxwidgets
9e1597e
@androidnisse
wxmaxima: rebuild for wxwidgets
d6218e6
@androidnisse
gnuplot: rebuild for wxwidgets
6a8763f
@androidnisse
tv-lite: rebuild for wxwidgets
2e35110
@androidnisse
audacity: rebuild for wxwidgets
5c81f19
@androidnisse
aegisub: rebuild for wxwidgets
0c897d9
@androidnisse
freefilesync: rebuild for wxwidgets
454cab1
@androidnisse
hugin: rebuild for wxwidgets
3e53283
@androidnisse
wxPython: update to 4.2.2
fc9f6a0
@androidnisse
visualboyadvance-m: rebuild against wxwidgets
ecb1e38
@malfisya @androidnisse
kicad: rebuild against wxwidgets
e4110b5
@androidnisse
trelby: rebuild for wxwidgets
aefde36
@malfisya malfisya mentioned this pull request Dec 23, 2024
Open
1 task
@EbonJaeger
Copy link
Member

Is this just waiting for 0ad?

@davidjharder
Copy link
Member

davidjharder commented Dec 24, 2024 •
edited
Loading

Not really. Oad doesn't build at the moment, but it's not a wxwidgets issue, as far as i can tell

@androidnisse
Copy link
Contributor Author

Is this just waiting for 0ad?

Not really. Oad doesn't build at the moment, but it's not a wxwidgets issue, as far as i can tell

So can this go in now? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EbonJaeger EbonJaeger Awaiting requested review from EbonJaeger

@malfisya malfisya Awaiting requested review from malfisya

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Solus
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please update wxwidgets to 3.2.5 or higher to resolve crash with veracrypt
4 participants
@androidnisse @davidjharder @malfisya @EbonJaeger