-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jabref: Update to 5.15 along with packaging fixes #3605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's including a bundled version of Java in the package. I don't think that's what we want to do.
Yes. I think you are right. I see that now. i'll see what I can do. |
2765637
to
be07105
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't get it to build on my system.
Warning] ypkg-build should be run via fakeroot, not as real root user
[Info] Building jabref-5.15
[Build] Building native package
[Source] Extracting source
[Build] Running step: build
[Build] Enabling ccache
[Build] Enabling sccache
+ cd /home/build/YPKG/root/jabref/build/jabref-5.15
+ export 'CFLAGS=-mtune=generic -march=x86-64 -g2 -O2 -pipe -fPIC -fno-plt -Wformat -Wformat-security -D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=32 -fasynchronous-unwind-tables -ftree-vectorize -feliminate-unused-debug-types -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wno-error -Wp,-D_REENTRANT'
+ CFLAGS='-mtune=generic -march=x86-64 -g2 -O2 -pipe -fPIC -fno-plt -Wformat -Wformat-security -D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=32 -fasynchronous-unwind-tables -ftree-vectorize -feliminate-unused-debug-types -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wno-error -Wp,-D_REENTRANT'
+ export 'CXXFLAGS=-mtune=generic -march=x86-64 -g2 -O2 -pipe -fPIC -fno-plt -D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=32 -fasynchronous-unwind-tables -ftree-vectorize -feliminate-unused-debug-types -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wno-error -Wp,-D_REENTRANT'
+ CXXFLAGS='-mtune=generic -march=x86-64 -g2 -O2 -pipe -fPIC -fno-plt -D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=32 -fasynchronous-unwind-tables -ftree-vectorize -feliminate-unused-debug-types -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wno-error -Wp,-D_REENTRANT'
+ export 'LDFLAGS=-Wl,--copy-dt-needed-entries -Wl,-O1 -Wl,-z,relro -Wl,-z,now -Wl,-z,max-page-size=0x1000 -Wl,-Bsymbolic-functions -Wl,--sort-common -Wl,-z,pack-relative-relocs'
+ LDFLAGS='-Wl,--copy-dt-needed-entries -Wl,-O1 -Wl,-z,relro -Wl,-z,now -Wl,-z,max-page-size=0x1000 -Wl,-Bsymbolic-functions -Wl,--sort-common -Wl,-z,pack-relative-relocs'
+ export RUSTFLAGS=-Cforce-frame-pointers
+ RUSTFLAGS=-Cforce-frame-pointers
+ export 'FFLAGS=-mtune=generic -march=x86-64 -g2 -O2 -pipe -fPIC -fno-plt -D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=32 -fasynchronous-unwind-tables -ftree-vectorize -feliminate-unused-debug-types -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wno-error -Wp,-D_REENTRANT'
+ FFLAGS='-mtune=generic -march=x86-64 -g2 -O2 -pipe -fPIC -fno-plt -D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=32 -fasynchronous-unwind-tables -ftree-vectorize -feliminate-unused-debug-types -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wno-error -Wp,-D_REENTRANT'
+ export 'FCFLAGS=-mtune=generic -march=x86-64 -g2 -O2 -pipe -fPIC -fno-plt -D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=32 -fasynchronous-unwind-tables -ftree-vectorize -feliminate-unused-debug-types -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wno-error -Wp,-D_REENTRANT'
+ FCFLAGS='-mtune=generic -march=x86-64 -g2 -O2 -pipe -fPIC -fno-plt -D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=32 -fasynchronous-unwind-tables -ftree-vectorize -feliminate-unused-debug-types -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wall -Wno-error -Wp,-D_REENTRANT'
+ export PATH=/usr/lib64/ccache/bin:/usr/bin:/bin:/usr/sbin:/sbin
+ PATH=/usr/lib64/ccache/bin:/usr/bin:/bin:/usr/sbin:/sbin
+ export workdir=/home/build/YPKG/root/jabref/build/jabref-5.15
+ workdir=/home/build/YPKG/root/jabref/build/jabref-5.15
+ export package=jabref
+ package=jabref
+ export release=5
+ release=5
+ export version=5.15
+ version=5.15
+ export sources=/home/build/YPKG/sources
+ sources=/home/build/YPKG/sources
+ export pkgfiles=/home/build/work/files
+ pkgfiles=/home/build/work/files
+ export installdir=/home/build/YPKG/root/jabref/install
+ installdir=/home/build/YPKG/root/jabref/install
+ export PKG_ROOT_DIR=/home/build/YPKG/root/jabref
+ PKG_ROOT_DIR=/home/build/YPKG/root/jabref
+ export PKG_BUILD_DIR=/home/build/YPKG/root/jabref/build
+ PKG_BUILD_DIR=/home/build/YPKG/root/jabref/build
+ export LT_SYS_LIBRARY_PATH=/usr/lib64
+ LT_SYS_LIBRARY_PATH=/usr/lib64
+ export CC=x86_64-solus-linux-gcc
+ CC=x86_64-solus-linux-gcc
+ export CXX=x86_64-solus-linux-g++
+ CXX=x86_64-solus-linux-g++
+ export LD_AS_NEEDED=1
+ LD_AS_NEEDED=1
+ export RUSTC_WRAPPER=/usr/bin/sccache
+ RUSTC_WRAPPER=/usr/bin/sccache
+ export CCACHE_BASEDIR=/home/build/YPKG/root/jabref/build/jabref-5.15
+ CCACHE_BASEDIR=/home/build/YPKG/root/jabref/build/jabref-5.15
+ export SOURCE_DATE_EPOCH=1730246400
+ SOURCE_DATE_EPOCH=1730246400
+ unset DISPLAY SUDO_USER SUDO_GID SUDO_UID SUDO_COMMAND CDPATH
+ export JAVA_HOME=/usr/lib64/openjdk-21
+ JAVA_HOME=/usr/lib64/openjdk-21
+ export PATH=/usr/lib64/openjdk-21/bin:/usr/lib64/ccache/bin:/usr/bin:/bin:/usr/sbin:/sbin
+ PATH=/usr/lib64/openjdk-21/bin:/usr/lib64/ccache/bin:/usr/bin:/bin:/usr/sbin:/sbin
+ export GRADLE_USER_HOME=/home/build/YPKG/root/jabref/build/jabref-5.15
+ GRADLE_USER_HOME=/home/build/YPKG/root/jabref/build/jabref-5.15
+ gradle assemble --no-daemon --no-build-cache -PprojVersionInfo=5.15 -PprojVersion=5.15
Welcome to Gradle 8.10.2!
Here are the highlights of this release:
- Support for Java 23
- Faster configuration cache
- Better configuration cache reports
For more details see https://docs.gradle.org/8.10.2/release-notes.html
To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/8.10.2/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
Daemon will be stopped at the end of the build
FAILURE: Build failed with an exception.
* What went wrong:
A problem occurred configuring root project 'JabRef'.
> Could not resolve all artifacts for configuration ':classpath'.
> Could not resolve com.github.koppor.gradle-modules-plugin:gradle-modules-plugin:jitpack-SNAPSHOT.
Required by:
root project : > com.github.koppor:gradle-modules-plugin:jitpack-SNAPSHOT:33f60fd812-1
> Could not resolve com.github.koppor.gradle-modules-plugin:gradle-modules-plugin:jitpack-SNAPSHOT.
> Could not get resource 'https://jitpack.io/com/github/koppor/gradle-modules-plugin/gradle-modules-plugin/jitpack-SNAPSHOT/gradle-modules-plugin-jitpack-33f60fd812-1.pom'.
> Could not GET 'https://jitpack.io/com/github/koppor/gradle-modules-plugin/gradle-modules-plugin/jitpack-SNAPSHOT/gradle-modules-plugin-jitpack-33f60fd812-1.pom'.
> Read timed out
> There are 6 more failures with identical causes.
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.
BUILD FAILED in 3m 24s
2 actionable tasks: 2 executed
Command '['/bin/bash', '--norc', '--noprofile', '/tmp/ypkg-buildfp46itk8']' returned non-zero exit status 1.
[Build] build failed for jabref
✗ Failed to build packages err="Failed to start build of package, reason: exit status 1\n"
task: Failed to run task "build-local": exit status 1
Same here |
It looks like that plugin longer is available. This no longer builds for me either. I have reached out to the JabRef team asking for assistance / clarification on this plugin. --- 2 hours later --- I don't know if this is a risky situation and I need to do more research on it.. or if it builds, it builds :) In the meantime, could you please try again? It is working for me now with no changes and I have cleared the cache and rebuilt successfully a few times. |
Still getting a timeout on EDIT: Tried a wget and it worked eventually; took 2 minutes. Maybe timeout can be changed to ~5min. |
Ok, it built for me. Something is janky with downloading that one file. |
I had more successful rebuilds last night and again this morning with no changes. (US ET) |
It still keeps failing for me. The plugin is still the problem, maybe my location is the cause. So, I cannot verify the functionality of the package. If other staff can verify that jabref working properly, I will leave the review to them. |
Timed out for me as well. In Sweden. |
@A108384 add the timeout flags and I'll give it a shot on the build server. Let's try it |
**Summary** - Update from 5.5 to 5.15 [changelogs](https://github.com/JabRef/jabref/releases) - Add homepage to package.yml - Update to openjdk-21 - Include new MAINTAINERS.md - Include monitoring.yml - Include appstream metainfo - Resolves (getsolus#3086) - Resolves (getsolus#2642)
be07105
to
812eccb
Compare
I have finally updated the PR. It still failed to build a few times yesterday before it was successful. But then it has built successfully several times since. I also found this except in the jitpack.io FAQ
Therefore I used 180000 for the Timeout parameters. |
Successful build! |
Summary
Update from 5.5 to 5.15 changelogs
Add homepage to package.yml
Update to openjdk-21
Include new MAINTAINERS.md
Include monitoring.yml
Include appstream metainfo
Resolves #3089
Resolves #2642
Related to #1389
Test Plan
Checklist