Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heroic-games-launcher: Housekeeping #1425

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

malfisya
Copy link
Member

@malfisya malfisya commented Jan 24, 2024

Summary

Test Plan

  • Verified metadata with appsappstream-builder --packages-dir=. --include-failed -v
  • Verified homepage loads relevant informations
  • Make sure app icon in panel and overview are displayed correctly (tested on GNOME, Plasma, Budgie)

Checklist

  • Package was built and tested against unstable

**Summary**

- Install upstream appstream metadata (Part of getsolus#1389)
- Install upstream desktop file with StartupWMClass fixed
- Replaced homepage with a more representative one

**Test Plan**

- Verified metadata with `appsappstream-builder --packages-dir=. --include-failed -v`
- Verified homepage loads relevant informations
- Make sure app icon in panel and overview are displayed correctly (tested on GNOME, Plasma, Budgie)

**Checklist**

- [x] Package was built and tested against unstable
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@EbonJaeger EbonJaeger merged commit a2f6c09 into getsolus:main Jan 24, 2024
1 check passed
@malfisya malfisya deleted the heroic branch January 25, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants