-
Notifications
You must be signed in to change notification settings - Fork 90
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
**Summary** New printers added: - Brother DCP-7010 - Brother DCP-B7500D series - Brother DCP-L2560DW series - Brother HL-2240 series - Brother HL-2260D - Brother HL-5140 series - Brother HL-5370DW series - Brother HL-5450DN series - Brother HL-L2402D - Brother MFC-8440 - Brother MFC-L2690DW - Brother HL-L2400DW - Brother HL-L2405W Full changelog [here](https://github.com/Owl-Maintain/brlaser/releases/tag/v6.2.7) **Packaging** - Added patch and sed fixup to address duplex printing issues particular to Solus
- Loading branch information
1 parent
223c354
commit 962f88e
Showing
5 changed files
with
55 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
Author: Benjamin Lowell <[email protected]> | ||
Date: Wed Jan 22 02:08:25 2025 -0400 | ||
|
||
This patch addresses the issue of duplex printing not working as intended on Solus by setting Duplex Long edge to use `&l1S`. | ||
The reason this patch is needed is that only the PLC duplex settings are honored, and `Duplex rotated` in `brlaser.drv` is ignored. | ||
|
||
PCL Command Overview: | ||
&l2S: Duplex Short edge | ||
&l1S: Duplex Long edge | ||
&l0S: Simplex (one sided) | ||
|
||
This change has not been applied upstream for the following reasons: | ||
- When duplex support was added to `brlaser`, printing Duplex Long edge on the `DCP-7065DN` resulted in missing lines. | ||
- The workaround at the time involved always printing Short edge when duplexing, and rotating the reverse side by 180 degrees for Long edge printing. | ||
- It is unknown if the missing lines issue is still present when using `&l1S` for Duplex Long edge on select printers. | ||
|
||
Technically, `Duplex rotated` should be replaced with `Duplex normal` (in `brlaser.drv.in`), even though this change will not have a functional impact. | ||
Setting `Duplex normal` should avoid any further disruption if CUPS starts respecting the duplex settings in `brlaser.drv` at some point in the future. | ||
|
||
diff --git a/src/job.cc b/src/job.cc | ||
index 9cc5e35..bb3b25b 100644 | ||
--- a/src/job.cc | ||
+++ b/src/job.cc | ||
@@ -78,8 +78,10 @@ void job::write_page_header() { | ||
fputs("\033E", out_); | ||
fprintf(out_, "\033&l%dX", std::max(1, page_params_.num_copies)); | ||
|
||
- if (page_params_.duplex || page_params_.tumble) { | ||
+ if (page_params_.tumble) { | ||
fputs("\033&l2S", out_); | ||
+ } else if (page_params_.duplex) { | ||
+ fputs("\033&l1S", out_); | ||
} else { | ||
fputs("\033&l0S", out_); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
releases: | ||
id: ~ 376497 | ||
rss: https://github.com/Owl-Maintain/brlaser/tags.atom | ||
# No known CPE, checked 2025-01-21 | ||
security: | ||
cpe: ~ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,8 +3,8 @@ | |
<Name>brlaser</Name> | ||
<Homepage>https://github.com/Owl-Maintain/brlaser</Homepage> | ||
<Packager> | ||
<Name>Reilly Brogan</Name> | ||
<Email>[email protected]</Email> | ||
<Name>David Harder</Name> | ||
<Email>[email protected]</Email> | ||
</Packager> | ||
<License>GPL-2.0-or-later</License> | ||
<PartOf>drivers.printer</PartOf> | ||
|
@@ -25,12 +25,12 @@ | |
</Files> | ||
</Package> | ||
<History> | ||
<Update release="4"> | ||
<Date>2024-05-04</Date> | ||
<Version>6.2.6</Version> | ||
<Update release="5"> | ||
<Date>2025-01-22</Date> | ||
<Version>6.2.7</Version> | ||
<Comment>Packaging update</Comment> | ||
<Name>Reilly Brogan</Name> | ||
<Email>[email protected]</Email> | ||
<Name>David Harder</Name> | ||
<Email>[email protected]</Email> | ||
</Update> | ||
</History> | ||
</PISI> |