-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(admin): make profile events optional for trace queries #6779
Conversation
When would this happen? Did we purposefully not want the system query log ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think my comments are blocking but I am surprised that the system.query_log
wouldn't exist in some environments
@MeredithAnya gathering profile events can be slow (a few seconds), and sometimes we just want the trace output and the scrubbed query result, this would speed that up |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sometimes the system.query_log table doesn't exist in the environment. Right now that breaks the entire tool. Gathering profile events can also be quite slow and for long queries it can time out. Allow it to be optional in the UI