-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sourcemaps): Add sourcemapped subcolumn to errors #6772
base: master
Are you sure you want to change the base?
Conversation
This PR has a migration; here is the generated SQL for -- start migrations
-- forward migration events : 0025_add_sourcemapped_subcolumn_exception_frames
Local op: ALTER TABLE errors_local ADD COLUMN IF NOT EXISTS exception_frames.sourcemapped Array(Nullable(UInt8)) AFTER exception_frames.stack_level;
Distributed op: ALTER TABLE errors_dist ADD COLUMN IF NOT EXISTS exception_frames.sourcemapped Array(Nullable(UInt8)) AFTER exception_frames.stack_level;
-- end forward migration events : 0025_add_sourcemapped_subcolumn_exception_frames
-- backward migration events : 0025_add_sourcemapped_subcolumn_exception_frames
Distributed op: ALTER TABLE errors_dist DROP COLUMN IF EXISTS exception_frames.sourcemapped;
Local op: ALTER TABLE errors_local DROP COLUMN IF EXISTS exception_frames.sourcemapped;
-- end backward migration events : 0025_add_sourcemapped_subcolumn_exception_frames |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a check that doesn't allow migrations and snuba application code changes to be coupled in one PR. You could need to make two separate PRs (first merging the migration, then the yaml changes).
Thank you @enochtangg! I've separated out the yaml change into a separate PR |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Add
sourcemapped
subcolumn toexception_frames
column inerrors
tableModel changes: #6773