fix: bug in AttributeNames RPC endpoint, filter offset #6714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xurui-c
approved these changes
Jan 2, 2025
onkar
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
LGTM. Please verify if this fix also addresses https://github.com/getsentry/eap-planning/issues/140.
kylemumma
added a commit
that referenced
this pull request
Jan 2, 2025
There is an index out of range error with filter offset when the attribute results are empty. This PR solves this bug. The new test `test_empty_results` failed before (due to the bug), and now passes here is the sentry issue it fixes: https://sentry.sentry.io/issues/6189483746/?project=300688&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=date&statsPeriod=1h&stream_index=8 and it also closes this ticket getsentry/eap-planning#138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an index out of range error with filter offset when the attribute results are empty. This PR solves this bug.
The new test
test_empty_resultsfailed before (due to the bug), and now passeshere is the sentry issue it fixes: https://sentry.sentry.io/issues/6189483746/?project=300688&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=date&statsPeriod=1h&stream_index=8
and it also closes this ticket https://github.com/getsentry/eap-planning/issues/138