Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(job-runner): surface errors to Snuba admin #6704

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xurui-c
Copy link
Member

@xurui-c xurui-c commented Dec 30, 2024

Currently, errors are surfaced to GCP, and Snuba Admin just displays server error. I want to surface the actual error message to Snuba Admin as well

Copy link

sentry-io bot commented Dec 30, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: snuba/manual_jobs/runner.py

Function Unhandled Issue
run_job JobLockedException: Job inc-984.scrub-spans-user.whole-timerange.12_19_2024 lock exists, not available to run ...
Event Count: 1
run_job JobStatusException: Job inc-984.scrub-eap_spans-user.historical.12_20_2024 has run before, status = running, not avai... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@xurui-c xurui-c changed the title c feat(job-runner): surface errors to Snuba admin Dec 30, 2024
Copy link

codecov bot commented Jan 4, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1163 1 1162 3
View the top 1 failed tests by shortest run time
tests.manual_jobs.test_job_statuses::test_job_with_exception_causes_failure
Stack Traces | 0.029s run time
Traceback (most recent call last):
  File ".../tests/manual_jobs/test_job_statuses.py", line 48, in test_job_with_exception_causes_failure
    run_job(test_job_spec)
  File ".../snuba/manual_jobs/runner.py", line 141, in run_job
    raise e
  File ".../snuba/manual_jobs/runner.py", line 133, in run_job
    job_to_run.execute(job_logger)
  File ".../tests/manual_jobs/test_job_statuses.py", line 22, in execute
    raise SerializableException("Intended failure")
snuba.utils.serializable_exception.SerializableException: Intended failure

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@xurui-c xurui-c marked this pull request as ready for review January 4, 2025 00:26
@xurui-c xurui-c requested a review from a team as a code owner January 4, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant