Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CapMan visibility] change default throttling values for BytesScannedRejectingPolicy #6026

Merged

Conversation

xurui-c
Copy link
Member

@xurui-c xurui-c commented Jun 12, 2024

I confirm that BytesScannedRejectingPolicy's throttling works as intended within S4S, so it's safe to make throttling effective.

Copy link

codecov bot commented Jun 12, 2024

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2466 tests with 1 failed, 2461 passed and 4 skipped.

View the full list of failed tests
Test Description Failure message
Testsuite:
pytest

Test name:
tests.web.test_db_query::test_db_query_ignore_consistent

Envs:
- default
Traceback (most recent call last):
File ".../tests/web/test_db_query.py", line 721, in test_db_query_ignore_consistent
assert result.extra["stats"]["max_threads"] == 10
AssertionError: assert 5 == 10

@xurui-c xurui-c force-pushed the rachel/defaultThrottleValuesForBytesScannedRejectingPolicy branch from 36b5eb7 to 25a8a5e Compare June 12, 2024 21:17
@xurui-c xurui-c force-pushed the rachel/defaultThrottleValuesForBytesScannedRejectingPolicy branch from 25a8a5e to 707219f Compare June 12, 2024 21:44
@xurui-c xurui-c marked this pull request as ready for review June 12, 2024 22:04
@xurui-c xurui-c requested a review from a team as a code owner June 12, 2024 22:04
@xurui-c xurui-c requested review from onewland and volokluev June 12, 2024 22:04
@xurui-c xurui-c enabled auto-merge (squash) June 12, 2024 22:28
@xurui-c xurui-c disabled auto-merge June 12, 2024 22:30
@xurui-c xurui-c merged commit 0792882 into master Jun 12, 2024
29 checks passed
@xurui-c xurui-c deleted the rachel/defaultThrottleValuesForBytesScannedRejectingPolicy branch June 12, 2024 22:30
@xurui-c xurui-c changed the title [CapMan] change default throttling values for BytesScannedRejectingPolicy [CapMan visibility] change default throttling values for BytesScannedRejectingPolicy Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants