Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gocd): Updating canary checks to happen after the deploy goes out #6004

Merged
merged 1 commit into from
Jun 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions gocd/templates/pipelines/snuba.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -128,22 +128,14 @@ local deploy_canary_stage(region) =
'deploy-canary': {
timeout: 1200,
elastic_profile_id: 'snuba',
environment_variables: {
LABEL_SELECTOR: 'service=snuba,is_canary=true',
},
tasks: [
gocdtasks.script(importstr '../bash/deploy.sh'),
],
},
health_check: {
environment_variables: {
SENTRY_AUTH_TOKEN: '{{SECRET:[devinfra-sentryio][token]}}',
DATADOG_API_KEY: '{{SECRET:[devinfra][sentry_datadog_api_key]}}',
DATADOG_APP_KEY: '{{SECRET:[devinfra][sentry_datadog_app_key]}}',
LABEL_SELECTOR: 'service=snuba,is_canary=true',
},
elastic_profile_id: 'snuba',
tasks: [
gocdtasks.script(importstr '../bash/deploy.sh'),
gocdtasks.script(importstr '../bash/canary-ddog-health-check.sh'),
],
},
Expand Down
Loading