fix: Commit offsets from strategy join #4936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return value of Strategy.join() is currently ignored, because we have no access to the consumer from within the assignment callbacks. Shuffle a few things around so that consumer callbacks contain Arc to the consumer internally.
untitaker
commented
Oct 27, 2023
| @@ -69,7 +76,11 @@ impl<TPayload: 'static + Clone> AssignmentCallbacks for Callbacks<TPayload> { | |||
| s.close(); | |||
| // TODO: We need to actually call consumer.commit() with the commit request. | |||
| // Right now we are never committing during consumer shutdown. | |||
| let _ = s.join(None); | |||
| if let Some(commit_request) = s.join(None) { | |||
There was a problem hiding this comment.
this is the actual fix we're enabling
|
This has stopped committing anything in prod, reverting |
|
revert failed (conflict? already reverted?) -- check the logs |
lynnagara
added a commit
that referenced
this pull request
Oct 31, 2023
This reverts commit c7f4213. Consumer has stopped committing entirely, reverting to figure out why
lynnagara
added a commit
that referenced
this pull request
Oct 31, 2023
lynnagara
added a commit
that referenced
this pull request
Oct 31, 2023
Initial refactoring so that the consumer can be shared and referenced within the assignment callbacks. This is necessary so we can do things like call commit on the consumer during rebalance callbacks. This PR is based on #4936 which had to be reverted as the consumer fully stopped committing when that was merged. Though this is only the initial refactoring and does not actually commit during join yet. At the moment my best guess of why the previous attempt did not work in prod was the the context was being mutated after the consumer was initially created. This version avoids doing this and keeps the original approach of deferring consumer creation until StreamProcessor.subscribe() is called.
lynnagara
added a commit
that referenced
this pull request
Nov 2, 2023
Initial refactoring so that the consumer can be shared and referenced within the assignment callbacks. This is necessary so we can do things like call commit on the consumer during rebalance callbacks. This PR is based on #4936 which had to be reverted as the consumer fully stopped committing when that was merged. Though this is only the initial refactoring and does not actually commit during join yet. At the moment my best guess of why the previous attempt did not work in prod was the the context was being mutated after the consumer was initially created. This version avoids doing this and keeps the original approach of deferring consumer creation until StreamProcessor.subscribe() is called.
lynnagara
added a commit
that referenced
this pull request
Nov 6, 2023
lynnagara
added a commit
that referenced
this pull request
Nov 9, 2023
untitaker
pushed a commit
to getsentry/arroyo
that referenced
this pull request
Jan 17, 2024
Initial refactoring so that the consumer can be shared and referenced within the assignment callbacks. This is necessary so we can do things like call commit on the consumer during rebalance callbacks. This PR is based on getsentry/snuba#4936 which had to be reverted as the consumer fully stopped committing when that was merged. Though this is only the initial refactoring and does not actually commit during join yet. At the moment my best guess of why the previous attempt did not work in prod was the the context was being mutated after the consumer was initially created. This version avoids doing this and keeps the original approach of deferring consumer creation until StreamProcessor.subscribe() is called.
untitaker
pushed a commit
to getsentry/arroyo
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return value of Strategy.join() is currently ignored, because we
have no access to the consumer from within the assignment callbacks.
Shuffle a few things around so that consumer callbacks contain Arc to
the consumer internally.
SNS-2473