add more catches

getsentry · Jan 14, 2025 · a29e364 · a29e364
1 parent 4193562
commit a29e364
Showing 1 changed file with 21 additions and 11 deletions.
diff --git a/snuba/admin/static/clickhouse_queries/query_display.tsx b/snuba/admin/static/clickhouse_queries/query_display.tsx
@@ -143,17 +143,27 @@ function QueryDisplay(props: {
   }
 
   function handleQueryError(error: any) {
-    const lines = error.error.split("\n");
-    if (lines.length > 1) {
-      setQueryError({
-        title: lines[0],
-        body: lines.slice(1).join("\n"),
-      })
-    } else {
-      setQueryError({
-        title: error,
-        body: ""
-      });
+    try {
+      // this block assumes that the error is an object with an error property,
+      // if its not it will be caught by the catch block
+      const lines = error.error.split("\n");
+      if (lines.length > 1) {
+        setQueryError({
+          title: lines[0],
+          body: lines.slice(1).join("\n"),
+        })
+      } else {
+        setQueryError({
+          title: "Error",
+          body: lines[0]
+        });
+      }
+    } catch (e) {
+      if (typeof error === "object") {
+        setQueryError({ title: "Error", body: JSON.stringify(error) });
+      } else {
+        setQueryError({ title: "Error", body: error.toString() });
+      }
     }
   }