mypy

getsentry · Jan 15, 2025 · 11a9ad5 · 11a9ad5
1 parent fa20128
commit 11a9ad5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/snuba/web/rpc/v1/endpoint_get_traces.py b/snuba/web/rpc/v1/endpoint_get_traces.py
@@ -218,7 +218,7 @@ def _select_supported_filters(
         return next(
             f.filter
             for f in filters
-            if f.item_name == TraceItemType.TRACE_ITEM_TYPE_SPAN
+            if f.item_type == TraceItemType.TRACE_ITEM_TYPE_SPAN
         )
     except StopIteration:
         raise BadSnubaRPCRequestException("Only one span filter is supported.")

diff --git a/snuba/web/rpc/v1/endpoint_trace_item_table.py b/snuba/web/rpc/v1/endpoint_trace_item_table.py
@@ -103,5 +103,5 @@ def _execute(self, in_msg: TraceItemTableRequest) -> TraceItemTableResponse:
         # for backwards compatibility
         if in_msg.meta.trace_item_type == TraceItemType.TRACE_ITEM_TYPE_UNSPECIFIED:
             in_msg.meta.trace_item_type = TraceItemType.TRACE_ITEM_TYPE_SPAN
-        resolver = self.get_resolver(in_msg.meta.trace_item_name)
+        resolver = self.get_resolver(in_msg.meta.trace_item_type)
         return resolver.resolve(in_msg)
diff --git a/tests/web/rpc/v1/test_endpoint_get_traces.py b/tests/web/rpc/v1/test_endpoint_get_traces.py
@@ -295,7 +295,7 @@ def test_with_data_and_filter(self, setup_teardown: Any) -> None:
             ),
             filters=[
                 GetTracesRequest.TraceFilter(
-                    item_name=TraceItemType.TRACE_ITEM_TYPE_SPAN,
+                    item_type=TraceItemType.TRACE_ITEM_TYPE_SPAN,
                     filter=TraceItemFilter(
                         comparison_filter=ComparisonFilter(
                             key=AttributeKey(
@@ -383,7 +383,7 @@ def test_with_data_and_aggregated_fields(self, setup_teardown: Any) -> None:
             ],
             filters=[
                 GetTracesRequest.TraceFilter(
-                    item_name=TraceItemType.TRACE_ITEM_TYPE_SPAN,
+                    item_type=TraceItemType.TRACE_ITEM_TYPE_SPAN,
                     filter=TraceItemFilter(
                         comparison_filter=ComparisonFilter(
                             key=AttributeKey(