Skip to content

fix(taskworker) Improve metrics for scheduler #93051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

Conversation

markstory
Copy link
Member

Add a taskname dimension to scheduled tasks so that we can filter and breakdown scheduler operations.

Add a taskname dimension to scheduled tasks so that we can filter and
breakdown scheduler operations.
@markstory markstory requested a review from a team as a code owner June 6, 2025 19:02
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 6, 2025
logger.info("taskworker.scheduler.delay_task", extra={"task": entry.fullname})
metrics.incr("taskworker.scheduler.delay_task")
logger.info("taskworker.scheduler.delay_task", extra={"fullname": entry.fullname})
metrics.incr("taskworker.scheduler.delay_task", tags={"taskname": entry.taskname})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to get namespace in this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can add that as well.

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93051      +/-   ##
==========================================
+ Coverage   86.58%   87.91%   +1.33%     
==========================================
  Files       10284    10295      +11     
  Lines      590365   591287     +922     
  Branches    22961    22961              
==========================================
+ Hits       511175   519856    +8681     
+ Misses      78743    70984    -7759     
  Partials      447      447              

@markstory markstory merged commit f4e0eba into master Jun 9, 2025
61 checks passed
@markstory markstory deleted the fix-scheduler-metrics branch June 9, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants