fix(taskworker) Improve metrics for scheduler #93051
Merged
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a taskname dimension to scheduled tasks so that we can filter and breakdown scheduler operations.
github-actions
bot
added
the
Scope: Backend
evanh
approved these changes
Jun 9, 2025
evanh
reviewed
Jun 9, 2025
| logger.info("taskworker.scheduler.delay_task", extra={"task": entry.fullname}) | ||
| metrics.incr("taskworker.scheduler.delay_task") | ||
| logger.info("taskworker.scheduler.delay_task", extra={"fullname": entry.fullname}) | ||
| metrics.incr("taskworker.scheduler.delay_task", tags={"taskname": entry.taskname}) |
There was a problem hiding this comment.
Is there a way to get namespace in this?
There was a problem hiding this comment.
Yes, I can add that as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93051 +/- ##
==========================================
+ Coverage 86.58% 87.91% +1.33%
==========================================
Files 10284 10295 +11
Lines 590365 591287 +922
Branches 22961 22961
==========================================
+ Hits 511175 519856 +8681
+ Misses 78743 70984 -7759
Partials 447 447 |
evanh
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a taskname dimension to scheduled tasks so that we can filter and breakdown scheduler operations.