Skip to content

Streamline Uptime Monitor Creation #93042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Streamline Uptime Monitor Creation #93042

wants to merge 1 commit into from

Conversation

smeubank
Copy link
Member

@smeubank smeubank commented Jun 6, 2025

Uptime Monitor are created as an alert type. But the creation process is unique from a UI POV. This PR just updates a few things to hopefully make it easier for more users to create additional uptime monitors.

  • Title: New Alert Rule -> Create Uptime Monitor
  • default env selection when only one
  • have use URL and metho, move the rest below in some small font advanced config collapsed panel
  • establish ownership: let's remove clicks so they can click create rule
    • suggest a name, similar to what we do for projects

assist from cursor

image

@smeubank
Streamline Uptime Monitor Creation
5d61313 
Uptime Monitor are created as an alert type. But the creation process is unique from a UI POV. This PR just updates a few things to hopefully make it easier for more users to create additional uptime monitors.

- Title: New Alert Rule -> Create Uptime Monitor
- default env selection when only one
- have use URL and metho, move the rest below in some small font advanced config collapsed panel
- establish ownership: let's remove clicks so they can click create rule
  - suggest a name, similar to what we do for projects
@smeubank smeubank requested review from a team as code owners June 6, 2025 17:47
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 6, 2025
@evanpurkhiser
Copy link
Member

if you want to split some of this into individual PRs I can approve the ones that are straight forward

@codecov Codecov
Copy link

codecov bot commented Jun 6, 2025 •
edited
Loading

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
10510 4 10506 9
View the top 3 failed test(s) by shortest run time 
Uptime Alert Form can edit an existing rule
Stack Traces | 0.263s run time 
TestingLibraryElementError: Unable to find an accessible element with the role "textbox" and name "Interval"

Here are the accessible roles:

  list:

  Name "":
  ...

  --------------------------------------------------
  listitem:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  link:

  Name "View Project Details":
  ...

  Name "Learn more":
  ...

  --------------------------------------------------
  img:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  textbox:

  Name "Project":
  ...

  Name "Environment":
  ...

  Name "URL":
  ...

  Name "Method":
  ...

  Name "Uptime rule name":
  ...

  Name "Owner":
  ...

  --------------------------------------------------
  button:

  Name "":
  ...

  Name "Save Rule":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  code:

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:95:19
    at input (.../rules/uptime/uptimeAlertForm.spec.tsx:34:40)
    at Object.<anonymous> (.../rules/uptime/uptimeAlertForm.spec.tsx:187:39)
Uptime Alert Form renders existing rule
Stack Traces | 0.311s run time 
TestingLibraryElementError: Unable to find an accessible element with the role "textbox" and name "Body"

Here are the accessible roles:

  list:

  Name "":
  ...

  --------------------------------------------------
  listitem:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  link:

  Name "View Project Details":
  ...

  Name "Learn more":
  ...

  --------------------------------------------------
  img:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  textbox:

  Name "Project":
  ...

  Name "Environment":
  ...

  Name "URL":
  ...

  Name "Method":
  ...

  Name "Uptime rule name":
  ...

  Name "Owner":
  ...

  --------------------------------------------------
  button:

  Name "":
  ...

  Name "Save Rule":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  code:

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:95:19
    at input (.../rules/uptime/uptimeAlertForm.spec.tsx:34:40)
    at Object.<anonymous> (.../rules/uptime/uptimeAlertForm.spec.tsx:115:12)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
Uptime Alert Form can create a new rule
Stack Traces | 0.39s run time 
TestingLibraryElementError: Unable to find an accessible element with the role "slider" and name "Timeout"

Here are the accessible roles:

  list:

  Name "":
  ...

  --------------------------------------------------
  listitem:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  link:

  Name "View Project Details":
  ...

  Name "Learn more":
  ...

  --------------------------------------------------
  img:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  textbox:

  Name "Project":
  ...

  Name "Environment":
  ...

  Name "URL":
  ...

  Name "Method":
  ...

  Name "Uptime rule name":
  ...

  Name "Owner":
  ...

  --------------------------------------------------
  button:

  Name "Create Rule":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../rules/uptime/uptimeAlertForm.spec.tsx:47:49)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@smeubank
Copy link
Member Author

smeubank commented Jun 6, 2025

closing this and splitting into the following PRs

  1. feat(uptime): Change Monitor Creation page title #93061
  2. feat(uptime)Create Advanced Config Section #93064
  3. feat(uptime):add-config-defaults #93066

@smeubank smeubank closed this Jun 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smeubank @evanpurkhiser