♻️ ref(aci): update links in issue alert titles #89240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
GabeVillalobos
approved these changes
Apr 9, 2025
Comment on lines
+61
to
+68
| if features.has("organizations:workflow-engine-ui-links", self.group.organization): | ||
| rule_id = int(get_key_from_rule_data(self.rules[0], "workflow_id")) | ||
| elif features.has( | ||
| "organizations:workflow-engine-trigger-actions", self.group.organization | ||
| ): | ||
| rule_id = int(get_key_from_rule_data(self.rules[0], "legacy_rule_id")) | ||
| else: | ||
| rule_id = self.rules[0].id |
There was a problem hiding this comment.
I'm really starting to think we could use a utility method for this now. Seems like we implement this logic in a few places.
Comment on lines
+196
to
+199
| if ( | ||
| environment_id is not None | ||
| and (environment_name := fetch_environment_name(environment_id)) is not None | ||
| ): |
There was a problem hiding this comment.
Mostly curious, when can environment_id be none?
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #89240 +/- ##
==========================================
+ Coverage 82.65% 87.71% +5.06%
==========================================
Files 10106 10123 +17
Lines 571872 572803 +931
Branches 22477 22477
==========================================
+ Hits 472703 502462 +29759
+ Misses 98732 69904 -28828
Partials 437 437 |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr updates
get_title_linkmethod in our notification builder to work with notification action and when the new ui rolls out.we fetch
legacy_rule_idif the notification action is invokedOR
we fetch
workflow_idif the new ui flag is enabled