fix(snuba): xfail test that is blocking Snuba CI #66980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one test fails in Snuba CI, however I have been completely unable to reproduce this failure in any other environment. That includes prod, because the change that breaks this (removing query splitters in Snuba) is currently running in prod. It is also extremely difficult to debug this problem using just CI. So, this test will be xfail'd for now, then after the Snuba change is merged in, I can debug this test in a much easier way.
enochtangg
approved these changes
Mar 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66980 +/- ##
==========================================
- Coverage 84.28% 84.19% -0.09%
==========================================
Files 5308 5306 -2
Lines 237405 237277 -128
Branches 41067 41044 -23
==========================================
- Hits 200086 199773 -313
- Misses 37101 37286 +185
Partials 218 218 |
JonasBa
pushed a commit
that referenced
this pull request
Mar 17, 2024
This one test fails in Snuba CI, however I have been completely unable to reproduce this failure in any other environment. That includes prod, because the change that breaks this (removing query splitters in Snuba) is currently running in prod. It is also extremely difficult to debug this problem using just CI. So, this test will be xfail'd for now, then after the Snuba change is merged in, I can debug this test in a much easier way. Snuba change in question: getsentry/snuba#5571
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one test fails in Snuba CI, however I have been completely unable to
reproduce this failure in any other environment. That includes prod, because
the change that breaks this (removing query splitters in Snuba) is currently
running in prod.
It is also extremely difficult to debug this problem using just CI. So, this
test will be xfail'd for now, then after the Snuba change is merged in, I can
debug this test in a much easier way.
Snuba change in question: getsentry/snuba#5571