Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add coverage upload to Codecov #781

Merged
merged 9 commits into from
Feb 7, 2025
Merged

Conversation

philprime
Copy link
Contributor

@philprime philprime commented Feb 6, 2025

  • Adds a Codecov configuration file with some default values. See the codecov.yml for comments on the select values.
  • Adds the Codecov GitHub-Action to the job_test and job_e2e_test
  • The coverage upload is configured not to fail the CI on error
  • The two upload steps are marked as unit-tests and e2e-tests so they should show up individually in Codecov

#skip-changelog

@philprime philprime requested a review from Lms24 February 6, 2025 15:59
@philprime philprime self-assigned this Feb 6, 2025
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we merge this, would you mind leaving a line or two in the PR description about what specifically we configured? thanks!

codecov.yml Show resolved Hide resolved
@Lms24
Copy link
Member

Lms24 commented Feb 6, 2025

Are you planning adding the upload of coverage reports in a follow-up PR?

@philprime
Copy link
Contributor Author

@Lms24 thanks for pointing out that the upload of coverage is missing. I'll add it and update the PR description accordingly

@philprime philprime changed the title chore: add Codecov configuration file chore: add coverage upload to Codecov Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@philprime philprime requested a review from Lms24 February 7, 2025 08:52
@philprime
Copy link
Contributor Author

@Lms24 git is not doing what I want today, it committed the generated assets from the e2e tests.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@philprime philprime merged commit b82807c into master Feb 7, 2025
21 checks passed
@philprime philprime deleted the philprime/codecov-setup branch February 7, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants