-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add coverage upload to Codecov #781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we merge this, would you mind leaving a line or two in the PR description about what specifically we configured? thanks!
Are you planning adding the upload of coverage reports in a follow-up PR? |
@Lms24 thanks for pointing out that the upload of coverage is missing. I'll add it and update the PR description accordingly |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
@Lms24 git is not doing what I want today, it committed the generated assets from the e2e tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
codecov.yml
for comments on the select values.job_test
andjob_e2e_test
unit-tests
ande2e-tests
so they should show up individually in Codecov#skip-changelog