Skip to content

refactor(logs): remove UNSTABLE prefix from feature flag #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Jun 6, 2025

Renaming UNSTABLE_logs to logs.

Reasoning:

  • other SDKs are already shipping it without experimental
  • The only changes I see we would make to the API is extensions, such as allowing more types to be passed in or additional syntax to call e.g. the Display or Debug impl as in tracing. For this purpose, types can remain the same, only the macros would change under the hood to allow for these extensions.
  • UNSTABLE might lead to people not using the feature

#skip-changelog

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.85%. Comparing base (c4fe8fb) to head (68a3cf7).
Report is 1 commits behind head on lcian/feat/logs-batching-clean.

Additional details and impacted files
@@                        Coverage Diff                         @@
##           lcian/feat/logs-batching-clean     #832      +/-   ##
==================================================================
+ Coverage                           72.84%   72.85%   +0.01%     
==================================================================
  Files                                  64       64              
  Lines                                7732     7732              
==================================================================
+ Hits                                 5632     5633       +1     
+ Misses                               2100     2099       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the one hand, it would be good to publish a release with this still marked as UNSTABLE.
but on the other hand, we are far far away from having any kind of API (semver) stability, so it probably doesn’t matter anyway.

@lcian lcian merged commit 87c9b54 into lcian/feat/logs-batching-clean Jun 10, 2025
17 checks passed
@lcian lcian deleted the lcian/ref/logs-not-unstable branch June 10, 2025 09:49
lcian added a commit that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants