-
-
Notifications
You must be signed in to change notification settings - Fork 166
feat(logs): send logs in batches #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #831 +/- ##
==========================================
+ Coverage 72.62% 72.84% +0.21%
==========================================
Files 63 64 +1
Lines 7597 7732 +135
==========================================
+ Hits 5517 5632 +115
- Misses 2080 2100 +20 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, looks good.
we are going to change this implementation to use the batch processor approach
Looking forward to this. would this mean that we end up with only one background thread (or maybe two if we count the transport thread)?
Yeah, exactly. At least for logs and spans, but I don't see why we wouldn't use it for sessions as well. |
Implements a batcher for logs.
SessionFlusher
, with different thresholds.enable_logs
is false.