Skip to content

feat(sdk): re-export ErrorEvent and TransactionEvent types #4859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Enhancement

📜 Description

Re-exporting common types so users don't have to import @sentry/core.

💚 How did you test it?

sample apps

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

Copy link
Contributor

github-actions bot commented May 23, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4dd23a8

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙇

Copy link
Contributor

github-actions bot commented May 23, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 501.34 ms 492.36 ms -8.98 ms
Size 17.75 MiB 20.15 MiB 2.40 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b6f8ea2 472.49 ms 469.60 ms -2.89 ms
18ce5e8 450.83 ms 436.08 ms -14.75 ms
60d7316 418.46 ms 414.12 ms -4.34 ms
bd0ca38 418.14 ms 425.96 ms 7.82 ms
6f52f97 426.14 ms 421.65 ms -4.49 ms
48ad514 454.44 ms 470.33 ms 15.89 ms
205982c 504.41 ms 505.70 ms 1.29 ms
d8e8c67 448.79 ms 438.70 ms -10.09 ms
9cd0e9f 449.65 ms 433.39 ms -16.26 ms
30189be 440.46 ms 435.60 ms -4.85 ms

App size

Revision Plain With Sentry Diff
b6f8ea2 17.75 MiB 20.11 MiB 2.36 MiB
18ce5e8 17.74 MiB 20.10 MiB 2.36 MiB
60d7316 17.75 MiB 20.11 MiB 2.36 MiB
bd0ca38 17.75 MiB 20.13 MiB 2.38 MiB
6f52f97 17.75 MiB 20.13 MiB 2.38 MiB
48ad514 17.75 MiB 20.12 MiB 2.37 MiB
205982c 17.74 MiB 20.10 MiB 2.36 MiB
d8e8c67 17.74 MiB 20.10 MiB 2.36 MiB
9cd0e9f 17.74 MiB 20.08 MiB 2.34 MiB
30189be 17.75 MiB 20.11 MiB 2.36 MiB

Previous results on branch: kw-before-send-types

Startup times

Revision Plain With Sentry Diff
60f6abf 404.18 ms 426.62 ms 22.43 ms

App size

Revision Plain With Sentry Diff
60f6abf 17.75 MiB 20.15 MiB 2.40 MiB

Copy link
Contributor

github-actions bot commented May 23, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.08 ms 1213.24 ms -0.84 ms
Size 3.19 MiB 4.34 MiB 1.16 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c6f01ea+dirty 1229.52 ms 1237.16 ms 7.64 ms
9de3d45+dirty 1228.37 ms 1231.79 ms 3.42 ms
8ae23a7+dirty 1233.67 ms 1229.52 ms -4.15 ms
52c0562+dirty 1233.94 ms 1226.29 ms -7.65 ms
9b5b3f4+dirty 1213.67 ms 1215.65 ms 1.98 ms
9385d74+dirty 1239.51 ms 1245.88 ms 6.37 ms
834729f+dirty 1213.61 ms 1203.33 ms -10.29 ms
d0bf494+dirty 1266.20 ms 1267.52 ms 1.32 ms
baad1d9+dirty 1251.59 ms 1245.84 ms -5.76 ms
60ad48c+dirty 1225.79 ms 1233.51 ms 7.72 ms

App size

Revision Plain With Sentry Diff
c6f01ea+dirty 2.92 MiB 3.69 MiB 789.94 KiB
9de3d45+dirty 3.19 MiB 4.33 MiB 1.14 MiB
8ae23a7+dirty 2.92 MiB 3.66 MiB 757.67 KiB
52c0562+dirty 2.92 MiB 3.69 MiB 794.15 KiB
9b5b3f4+dirty 3.19 MiB 4.35 MiB 1.16 MiB
9385d74+dirty 2.92 MiB 3.67 MiB 772.40 KiB
834729f+dirty 3.19 MiB 4.36 MiB 1.17 MiB
d0bf494+dirty 2.92 MiB 3.40 MiB 488.08 KiB
baad1d9+dirty 3.19 MiB 4.33 MiB 1.14 MiB
60ad48c+dirty 3.19 MiB 4.32 MiB 1.13 MiB

Previous results on branch: kw-before-send-types

Startup times

Revision Plain With Sentry Diff
60f6abf+dirty 1237.06 ms 1233.54 ms -3.52 ms

App size

Revision Plain With Sentry Diff
60f6abf+dirty 3.19 MiB 4.39 MiB 1.20 MiB

Copy link
Contributor

github-actions bot commented May 23, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.84 ms 1235.96 ms -0.88 ms
Size 2.63 MiB 3.77 MiB 1.14 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c6f01ea+dirty 1227.10 ms 1235.35 ms 8.24 ms
9de3d45+dirty 1229.16 ms 1229.58 ms 0.42 ms
8ae23a7+dirty 1230.02 ms 1227.62 ms -2.40 ms
52c0562+dirty 1219.34 ms 1221.25 ms 1.91 ms
9b5b3f4+dirty 1212.43 ms 1224.86 ms 12.42 ms
9385d74+dirty 1215.18 ms 1216.43 ms 1.25 ms
834729f+dirty 1214.95 ms 1224.79 ms 9.84 ms
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
baad1d9+dirty 1228.38 ms 1231.39 ms 3.01 ms
60ad48c+dirty 1214.22 ms 1227.41 ms 13.19 ms

App size

Revision Plain With Sentry Diff
c6f01ea+dirty 2.36 MiB 3.12 MiB 778.61 KiB
9de3d45+dirty 2.63 MiB 3.77 MiB 1.13 MiB
8ae23a7+dirty 2.36 MiB 3.10 MiB 752.42 KiB
52c0562+dirty 2.36 MiB 3.14 MiB 793.36 KiB
9b5b3f4+dirty 2.63 MiB 3.78 MiB 1.15 MiB
9385d74+dirty 2.36 MiB 3.10 MiB 759.78 KiB
834729f+dirty 2.63 MiB 3.79 MiB 1.16 MiB
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
baad1d9+dirty 2.63 MiB 3.76 MiB 1.13 MiB
60ad48c+dirty 2.63 MiB 3.75 MiB 1.12 MiB

Previous results on branch: kw-before-send-types

Startup times

Revision Plain With Sentry Diff
60f6abf+dirty 1233.80 ms 1240.16 ms 6.37 ms

App size

Revision Plain With Sentry Diff
60f6abf+dirty 2.63 MiB 3.82 MiB 1.19 MiB

Copy link
Contributor

github-actions bot commented May 23, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 382.81 ms 385.17 ms 2.36 ms
Size 7.15 MiB 8.42 MiB 1.26 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7f6695a+dirty 383.65 ms 365.36 ms -18.28 ms
60ad48c+dirty 373.40 ms 393.20 ms 19.80 ms
63ed251+dirty 485.02 ms 531.16 ms 46.14 ms
d997097+dirty 404.23 ms 477.09 ms 72.87 ms
d8e8c67+dirty 363.77 ms 408.66 ms 44.89 ms
eb597b3+dirty 456.71 ms 492.98 ms 36.26 ms
5bb8d5f+dirty 356.71 ms 389.65 ms 32.94 ms
623b5b8+dirty 388.77 ms 378.22 ms -10.55 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
e754436+dirty 424.60 ms 478.19 ms 53.59 ms

App size

Revision Plain With Sentry Diff
7f6695a+dirty 7.15 MiB 8.40 MiB 1.25 MiB
60ad48c+dirty 7.15 MiB 8.39 MiB 1.23 MiB
63ed251+dirty 7.15 MiB 8.35 MiB 1.20 MiB
d997097+dirty 7.15 MiB 8.38 MiB 1.23 MiB
d8e8c67+dirty 7.15 MiB 8.38 MiB 1.23 MiB
eb597b3+dirty 7.15 MiB 8.39 MiB 1.23 MiB
5bb8d5f+dirty 7.15 MiB 8.21 MiB 1.06 MiB
623b5b8+dirty 7.15 MiB 8.40 MiB 1.25 MiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
e754436+dirty 7.15 MiB 8.40 MiB 1.25 MiB

Previous results on branch: kw-before-send-types

Startup times

Revision Plain With Sentry Diff
60f6abf+dirty 462.04 ms 448.51 ms -13.53 ms

App size

Revision Plain With Sentry Diff
60f6abf+dirty 7.15 MiB 8.42 MiB 1.26 MiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman lucas-zimerman enabled auto-merge (squash) May 27, 2025 10:00
@lucas-zimerman lucas-zimerman merged commit 209f66f into main May 27, 2025
65 checks passed
@lucas-zimerman lucas-zimerman deleted the kw-before-send-types branch May 27, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants