Skip to content

!remove(sdk): Delete deprecated captureUserFeedback #4855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2025

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Refactoring

📜 Description

Remove deprecated captureUserFeedback, following JS SDK which also removed the old interface in v9.

https://docs.sentry.io/platforms/javascript/guides/react/migration/v8-to-v9/#removed-apis

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 465.61 ms 496.91 ms 31.29 ms
Size 17.75 MiB 19.55 MiB 1.81 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
8a54dff 482.57 ms 467.16 ms -15.41 ms
9fbcfaf 420.06 ms 435.31 ms 15.25 ms
9da5c4e 478.08 ms 467.46 ms -10.63 ms

App size

Revision Plain With Sentry Diff
8a54dff 17.75 MiB 19.54 MiB 1.80 MiB
9fbcfaf 17.75 MiB 19.54 MiB 1.79 MiB
9da5c4e 17.75 MiB 20.16 MiB 2.41 MiB

associatedEventId: feedback.event_id,
};
captureFeedback(feedbackParams);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove the SendFeedbackParams, UserFeedback and captureFeedback from the imports.
Apart from that and the changelog LGTM.
Thank you for removing the deprecated call 🙇

Copy link
Contributor

github-actions bot commented May 22, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.76 ms 1223.83 ms -6.93 ms
Size 2.63 MiB 3.76 MiB 1.13 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9fbcfaf+dirty 1216.66 ms 1212.06 ms -4.60 ms
9da5c4e+dirty 1231.84 ms 1235.49 ms 3.65 ms
8a54dff+dirty 1226.17 ms 1227.79 ms 1.63 ms

App size

Revision Plain With Sentry Diff
9fbcfaf+dirty 2.63 MiB 3.77 MiB 1.14 MiB
9da5c4e+dirty 2.63 MiB 3.76 MiB 1.13 MiB
8a54dff+dirty 2.63 MiB 3.79 MiB 1.16 MiB

Previous results on branch: remove-capture-user-feedback

Startup times

Revision Plain With Sentry Diff
4ae981e+dirty 1225.04 ms 1210.94 ms -14.10 ms

App size

Revision Plain With Sentry Diff
4ae981e+dirty 2.63 MiB 3.79 MiB 1.16 MiB

Copy link
Contributor

github-actions bot commented May 22, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 404.96 ms 394.00 ms -10.96 ms
Size 7.15 MiB 8.32 MiB 1.17 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
8a54dff+dirty 393.65 ms 392.32 ms -1.33 ms
9fbcfaf+dirty 417.92 ms 431.81 ms 13.90 ms
9da5c4e+dirty 399.70 ms 407.34 ms 7.64 ms

App size

Revision Plain With Sentry Diff
8a54dff+dirty 7.15 MiB 8.30 MiB 1.15 MiB
9fbcfaf+dirty 7.15 MiB 8.29 MiB 1.14 MiB
9da5c4e+dirty 7.15 MiB 8.42 MiB 1.27 MiB

Previous results on branch: remove-capture-user-feedback

Startup times

Revision Plain With Sentry Diff
4ae981e+dirty 384.96 ms 395.19 ms 10.23 ms

App size

Revision Plain With Sentry Diff
4ae981e+dirty 7.15 MiB 8.31 MiB 1.15 MiB

Copy link
Contributor

github-actions bot commented May 22, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.92 ms 1226.69 ms 0.77 ms
Size 3.19 MiB 4.33 MiB 1.14 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9fbcfaf+dirty 1215.22 ms 1222.26 ms 7.04 ms
9da5c4e+dirty 1215.41 ms 1226.38 ms 10.97 ms
8a54dff+dirty 1244.29 ms 1254.71 ms 10.43 ms

App size

Revision Plain With Sentry Diff
9fbcfaf+dirty 3.19 MiB 4.34 MiB 1.15 MiB
9da5c4e+dirty 3.19 MiB 4.33 MiB 1.14 MiB
8a54dff+dirty 3.19 MiB 4.35 MiB 1.17 MiB

Previous results on branch: remove-capture-user-feedback

Startup times

Revision Plain With Sentry Diff
4ae981e+dirty 1219.63 ms 1223.96 ms 4.33 ms

App size

Revision Plain With Sentry Diff
4ae981e+dirty 3.19 MiB 4.35 MiB 1.17 MiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙇

@antonis antonis merged commit c5ee1b6 into v7 May 28, 2025
68 of 69 checks passed
@antonis antonis deleted the remove-capture-user-feedback branch May 28, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants