Skip to content

chore(deps): v7: Bump Android SDK to v8.9.0 #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025
Merged

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Apr 23, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Bumps Android SDK from 8.8.0 to 8.9.0 targeting v7

💡 Motivation and Context

💚 How did you test it?

Manual, CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis antonis marked this pull request as ready for review April 23, 2025 15:41
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Ty!

Copy link
Contributor

github-actions bot commented Apr 23, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 411.54 ms 404.76 ms -6.79 ms
Size 17.75 MiB 19.54 MiB 1.79 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9da5c4e 478.08 ms 467.46 ms -10.63 ms
9fbcfaf 420.06 ms 435.31 ms 15.25 ms

App size

Revision Plain With Sentry Diff
9da5c4e 17.75 MiB 20.16 MiB 2.41 MiB
9fbcfaf 17.75 MiB 19.54 MiB 1.79 MiB

Copy link
Contributor

github-actions bot commented Apr 23, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 393.78 ms 395.48 ms 1.70 ms
Size 7.15 MiB 8.30 MiB 1.14 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9fbcfaf+dirty 417.92 ms 431.81 ms 13.90 ms
9da5c4e+dirty 399.70 ms 407.34 ms 7.64 ms

App size

Revision Plain With Sentry Diff
9fbcfaf+dirty 7.15 MiB 8.29 MiB 1.14 MiB
9da5c4e+dirty 7.15 MiB 8.42 MiB 1.27 MiB

Copy link
Contributor

github-actions bot commented Apr 23, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.94 ms 1234.48 ms 5.54 ms
Size 3.19 MiB 4.34 MiB 1.15 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9fbcfaf+dirty 1215.22 ms 1222.26 ms 7.04 ms
9da5c4e+dirty 1215.41 ms 1226.38 ms 10.97 ms

App size

Revision Plain With Sentry Diff
9fbcfaf+dirty 3.19 MiB 4.34 MiB 1.15 MiB
9da5c4e+dirty 3.19 MiB 4.33 MiB 1.14 MiB

CHANGELOG.md Outdated
- Bump Android SDK from v7.20.1 to v8.8.0 ([#4490](https://github.com/getsentry/sentry-react-native/pull/4490), [#4663](https://github.com/getsentry/sentry-react-native/pull/4663), [#4755](https://github.com/getsentry/sentry-react-native/pull/4755))
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#880)
- [diff](https://github.com/getsentry/sentry-java/compare/7.20.1...8.8.0)
- Bump Android SDK from v7.20.1 to v8.9.0 ([#4490](https://github.com/getsentry/sentry-react-native/pull/4490), [#4663](https://github.com/getsentry/sentry-react-native/pull/4663), [#4755](https://github.com/getsentry/sentry-react-native/pull/4755), [#4775](https://github.com/getsentry/sentry-react-native/pull/4775))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is getting quite large, shouldn't we keep the main PR with the main changes and only keep the latest PR that only bumped the version number?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense @lucas-zimerman 👍 Updated with c69debe

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a small note, but other than that lgtm!

@antonis antonis merged commit 61f61ca into v7 Apr 24, 2025
58 checks passed
@antonis antonis deleted the antonis/v7-android-8.9 branch April 24, 2025 06:22
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.80 ms 1239.31 ms 14.51 ms
Size 2.63 MiB 3.77 MiB 1.14 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9fbcfaf+dirty 1216.66 ms 1212.06 ms -4.60 ms
9da5c4e+dirty 1231.84 ms 1235.49 ms 3.65 ms

App size

Revision Plain With Sentry Diff
9fbcfaf+dirty 2.63 MiB 3.77 MiB 1.14 MiB
9da5c4e+dirty 2.63 MiB 3.76 MiB 1.13 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants