Autoinject feedback widget #4483

antonis · 2025-01-23T14:13:11Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Adds Sentry.showFeedbackForm() method that presents the feedback form in a Modal.

💡 Motivation and Context

Part of #4302

💚 How did you test it?

Manual, CI

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

samples/react-native/src/App.tsx

github-actions · 2025-01-23T14:25:34Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	457.52 ms	485.24 ms	27.72 ms
Size	17.75 MiB	20.12 MiB	2.37 MiB

Baseline results on branch: feedback-ui

Startup times

Revision	Plain	With Sentry	Diff
`e5d5735`	452.70 ms	453.04 ms	0.34 ms
`0459aee`	491.48 ms	486.13 ms	-5.35 ms
`2646c98`	429.98 ms	421.63 ms	-8.35 ms
`3e4cdf5`	462.35 ms	474.96 ms	12.61 ms
`0325426`	477.32 ms	457.43 ms	-19.89 ms
`269c976`	448.08 ms	428.86 ms	-19.22 ms

App size

Revision	Plain	With Sentry	Diff
`e5d5735`	17.75 MiB	20.12 MiB	2.37 MiB
`0459aee`	17.75 MiB	20.12 MiB	2.37 MiB
`2646c98`	17.75 MiB	20.12 MiB	2.37 MiB
`3e4cdf5`	17.75 MiB	20.12 MiB	2.37 MiB
`0325426`	17.75 MiB	20.12 MiB	2.37 MiB
`269c976`	17.75 MiB	20.12 MiB	2.37 MiB

Previous results on branch: antonis/feedback-autoinject

Startup times

Revision	Plain	With Sentry	Diff
`87cfc87`	429.98 ms	435.54 ms	5.56 ms

App size

Revision	Plain	With Sentry	Diff
`87cfc87`	17.75 MiB	20.12 MiB	2.37 MiB

github-actions · 2025-01-23T14:37:44Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1237.16 ms	1229.56 ms	-7.60 ms
Size	2.63 MiB	3.70 MiB	1.06 MiB

Baseline results on branch: feedback-ui

Startup times

Revision	Plain	With Sentry	Diff
`2646c98`+dirty	1218.51 ms	1218.92 ms	0.41 ms
`3e4cdf5`+dirty	1222.53 ms	1224.42 ms	1.89 ms
`e5d5735`+dirty	1222.02 ms	1222.22 ms	0.20 ms
`269c976`+dirty	1210.02 ms	1204.46 ms	-5.56 ms
`0325426`+dirty	1228.88 ms	1229.92 ms	1.04 ms
`0459aee`+dirty	1232.82 ms	1231.19 ms	-1.63 ms

App size

Revision	Plain	With Sentry	Diff
`2646c98`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`3e4cdf5`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`e5d5735`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`269c976`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`0325426`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`0459aee`+dirty	2.63 MiB	3.69 MiB	1.06 MiB

Previous results on branch: antonis/feedback-autoinject

Startup times

Revision	Plain	With Sentry	Diff
`87cfc87`+dirty	1221.21 ms	1222.85 ms	1.64 ms

App size

Revision	Plain	With Sentry	Diff
`87cfc87`+dirty	2.63 MiB	3.69 MiB	1.06 MiB

github-actions · 2025-01-23T14:39:16Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	370.12 ms	415.44 ms	45.32 ms
Size	7.15 MiB	8.39 MiB	1.23 MiB

Baseline results on branch: feedback-ui

Startup times

Revision	Plain	With Sentry	Diff
`269c976`+dirty	395.13 ms	438.37 ms	43.24 ms
`e5d5735`+dirty	377.37 ms	430.04 ms	52.67 ms
`0325426`+dirty	418.89 ms	485.00 ms	66.11 ms
`0459aee`+dirty	424.10 ms	466.63 ms	42.53 ms
`3e4cdf5`+dirty	642.13 ms	702.23 ms	60.10 ms
`2646c98`+dirty	415.13 ms	438.41 ms	23.28 ms

App size

Revision	Plain	With Sentry	Diff
`269c976`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`e5d5735`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`0325426`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`0459aee`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`3e4cdf5`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`2646c98`+dirty	7.15 MiB	8.38 MiB	1.23 MiB

Previous results on branch: antonis/feedback-autoinject

Startup times

Revision	Plain	With Sentry	Diff
`87cfc87`+dirty	390.11 ms	422.92 ms	32.81 ms

App size

Revision	Plain	With Sentry	Diff
`87cfc87`+dirty	7.15 MiB	8.39 MiB	1.23 MiB

github-actions · 2025-01-23T14:46:10Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1211.35 ms	1216.47 ms	5.12 ms
Size	3.19 MiB	4.26 MiB	1.07 MiB

Baseline results on branch: feedback-ui

Startup times

Revision	Plain	With Sentry	Diff
`269c976`+dirty	1223.29 ms	1222.90 ms	-0.39 ms
`0459aee`+dirty	1233.67 ms	1239.80 ms	6.12 ms
`0325426`+dirty	1210.17 ms	1216.37 ms	6.20 ms
`2646c98`+dirty	1239.94 ms	1246.90 ms	6.96 ms
`e5d5735`+dirty	1217.78 ms	1221.80 ms	4.02 ms

App size

Revision	Plain	With Sentry	Diff
`269c976`+dirty	3.19 MiB	4.26 MiB	1.07 MiB
`0459aee`+dirty	3.19 MiB	4.26 MiB	1.07 MiB
`0325426`+dirty	3.19 MiB	4.26 MiB	1.07 MiB
`2646c98`+dirty	3.19 MiB	4.26 MiB	1.07 MiB
`e5d5735`+dirty	3.19 MiB	4.26 MiB	1.07 MiB

packages/core/src/js/feedback/FeedbackFormManager.tsx

krystofwoldrich · 2025-01-24T20:53:45Z

I know this is still a draft, but after the modal is working let's add a test for the public function to ensure calling it displays the form when provider is used and doesn't throw error when provider is not used.

krystofwoldrich · 2025-01-24T21:04:44Z

We should also enable users to change the forms options/props. Similar to JS setting them in the integration options feedbackIntegration({}). But that can be a follow up PR to keep this consise.

krystofwoldrich · 2025-01-24T21:15:58Z

Modal is implemented in the legacy architecture for all versions the SDK supports.

But for new architecture only for RN 0.71 and up -> facebook/react-native#33652 (comment)

I think we could print error when we notice RN 0.70 and older and Fabric renderer (new arch).

I'm also adding this comment so we include this information in the docs.

This reverts commit db407ce.

antonis · 2025-01-27T09:21:38Z

Thank you for bringing this to my attention @krystofwoldrich 🙇

I think we could print error when we notice RN 0.70 and older and Fabric renderer (new arch).

I've added a check with 84108f1

antonis · 2025-01-27T11:50:44Z

Thank you for your help and feedback @krystofwoldrich 🙇

I know this is still a draft, but after the modal is working let's add a test for the public function to ensure calling it displays the form when provider is used and doesn't throw error when provider is not used.

Added tests with f4df57c

We should also enable users to change the forms options/props. Similar to JS setting them in the integration options feedbackIntegration({}). But that can be a follow up PR to keep this consise.

Makes sense 👍 I'll follow up with a separate PR for this.

packages/core/src/js/feedback/utils.ts

lucas-zimerman

Overall, the PR Looks good! Added a few suggestions but they are non-blocking

Co-authored-by: LucasZF <[email protected]>

krystofwoldrich · 2025-01-28T23:54:34Z

packages/core/test/feedback/FeedbackFormManager.test.tsx

+
+describe('FeedbackFormManager', () => {
+  it('showFeedbackForm displays the form when FeedbackFormProvider is used', () => {
+    require('../../src/js/feedback/utils').isModalSupported.mockReturnValue(true);


l: import { isModalSupported } from ''../../src/js/feedback/utils''; and then (isModalSupported as jest.MockedFunction<typeof isModalSupported>) should also work and it will be typesafe.

Good idea Krystof 👍
Updated with d8ab914

krystofwoldrich

Thank you. Looks good.

I left one small TS improvement comment in the test file.

antonis added 2 commits January 23, 2025 16:11

Auto-inject feedback form

638377d

Temporarily disable sample rotating indicator

db407ce

antonis commented Jan 23, 2025

View reviewed changes

samples/react-native/src/App.tsx Outdated Show resolved Hide resolved

This was referenced Jan 24, 2025

Autoinject feedback widget #4358

Closed

[EPIC] Feedback Widget for React Native #4302

Open

krystofwoldrich reviewed Jan 24, 2025

View reviewed changes

packages/core/src/js/feedback/FeedbackFormManager.tsx Outdated Show resolved Hide resolved

krystofwoldrich reviewed Jan 24, 2025

View reviewed changes

packages/core/src/js/feedback/FeedbackFormManager.tsx Outdated Show resolved Hide resolved

krystofwoldrich reviewed Jan 24, 2025

View reviewed changes

packages/core/src/js/feedback/FeedbackFormManager.tsx Outdated Show resolved Hide resolved

antonis added 5 commits January 27, 2025 09:17

Merge branch 'feedback-ui' into antonis/feedback-autoinject

7837b96

Revert "Temporarily disable sample rotating indicator"

e9f428d

This reverts commit db407ce.

Wrap Modal in a View

011fea7

Handles Android back button

a4962b9

Make modal style configurable

2d4abb3

antonis mentioned this pull request Jan 27, 2025

Update Set Up User Feedback documentation #4319

Closed

Print an error when the modal is not supported

84108f1

antonis added 2 commits January 27, 2025 11:25

Add changelog

587c3fc

Adds tests

f4df57c

antonis marked this pull request as ready for review January 27, 2025 11:52

antonis requested a review from lucas-zimerman as a code owner January 27, 2025 11:52

antonis requested a review from krystofwoldrich January 27, 2025 11:53

lucas-zimerman reviewed Jan 27, 2025

View reviewed changes

packages/core/src/js/feedback/utils.ts Outdated Show resolved Hide resolved

lucas-zimerman reviewed Jan 27, 2025

View reviewed changes

packages/core/src/js/feedback/utils.ts Outdated Show resolved Hide resolved

lucas-zimerman reviewed Jan 27, 2025

View reviewed changes

packages/core/src/js/feedback/utils.ts Outdated Show resolved Hide resolved

lucas-zimerman approved these changes Jan 27, 2025

View reviewed changes

antonis and others added 3 commits January 27, 2025 15:16

Get major, minor version with deconstruct declaration

0d466d2

Co-authored-by: LucasZF <[email protected]>

Remove if condition

caa075b

Co-authored-by: LucasZF <[email protected]>

Prettier

8071e8d

This was referenced Jan 27, 2025

feat: Feedback Widget for React Native #4435

Draft

Adds feedbackIntegration for configuring the feedback form #4485

Merged

krystofwoldrich reviewed Jan 28, 2025

View reviewed changes

krystofwoldrich approved these changes Jan 28, 2025

View reviewed changes

Fix test import

d8ab914

antonis merged commit eda1cb7 into feedback-ui Jan 29, 2025
64 of 66 checks passed

antonis deleted the antonis/feedback-autoinject branch January 29, 2025 08:55

This was referenced Jan 29, 2025

RN: Add feedback widget documentation getsentry/sentry-docs#12503

Open

Implements Report a Bug button #4378

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autoinject feedback widget #4483

Autoinject feedback widget #4483

antonis commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-autoinject

Startup times

App size

github-actions bot commented Jan 23, 2025 •

edited

Loading

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-autoinject

Startup times

App size

github-actions bot commented Jan 23, 2025 •

edited

Loading

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-autoinject

Startup times

App size

github-actions bot commented Jan 23, 2025

Baseline results on branch: feedback-ui

Startup times

App size

krystofwoldrich commented Jan 24, 2025

krystofwoldrich commented Jan 24, 2025

krystofwoldrich commented Jan 24, 2025

antonis commented Jan 27, 2025

antonis commented Jan 27, 2025 •

edited

Loading

lucas-zimerman left a comment •

edited

Loading

krystofwoldrich Jan 28, 2025

antonis Jan 29, 2025

krystofwoldrich left a comment

Autoinject feedback widget #4483

Autoinject feedback widget #4483

Conversation

antonis commented Jan 23, 2025 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Jan 23, 2025 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-autoinject

Startup times

App size

github-actions bot commented Jan 23, 2025 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-autoinject

Startup times

App size

github-actions bot commented Jan 23, 2025 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-autoinject

Startup times

App size

github-actions bot commented Jan 23, 2025

iOS (new) Performance metrics 🚀

Baseline results on branch: feedback-ui

Startup times

App size

krystofwoldrich commented Jan 24, 2025

krystofwoldrich commented Jan 24, 2025

krystofwoldrich commented Jan 24, 2025

antonis commented Jan 27, 2025

antonis commented Jan 27, 2025 • edited Loading

lucas-zimerman left a comment • edited Loading

Choose a reason for hiding this comment

krystofwoldrich Jan 28, 2025

Choose a reason for hiding this comment

antonis Jan 29, 2025

Choose a reason for hiding this comment

krystofwoldrich left a comment

Choose a reason for hiding this comment

antonis commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

antonis commented Jan 27, 2025 •

edited

Loading

lucas-zimerman left a comment •

edited

Loading