tests: bump test timeout for recursion stacktrace extract to 2s #4351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentrivana
reviewed
Apr 29, 2025
In some loaded environments, the test may take slightly longer than 1s to extract the stacktrace. This was noticed in nixpkgs build system where the load is generally high due to high build parallelism and resource constraints. I was sometimes getting failures because the time it took was e.g. ~1.2s (less than current timeout of 1s). Disclosure: we'll probably end up disabling the test in nixpkgs anyway because we try to avoid time sensitive tests. Regardless, this bump may help someone else in a similar situation or environment. Signed-off-by: Ihar Hrachyshka <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4351 +/- ##
==========================================
- Coverage 80.32% 80.31% -0.02%
==========================================
Files 142 142
Lines 15933 15935 +2
Branches 2725 2725
==========================================
Hits 12798 12798
Misses 2262 2262
- Partials 873 875 +2 |
|
Checked the failure and it doesn't seem related. |
sentrivana
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some loaded environments, the test may take slightly longer than 1s
to extract the stacktrace. This was noticed in nixpkgs build system
where the load is generally high due to high build parallelism and
resource constraints. I was sometimes getting failures because the time
it took was e.g. ~1.2s (less than current timeout of 1s).
Disclosure: we'll probably end up disabling the test in nixpkgs anyway
because we try to avoid time sensitive tests. Regardless, this bump may
help someone else in a similar situation or environment.
Signed-off-by: Ihar Hrachyshka [email protected]