Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(taskbroker): Improve fetch_next #69

Merged
merged 3 commits into from
Dec 6, 2024
Merged

feat(taskbroker): Improve fetch_next #69

merged 3 commits into from
Dec 6, 2024

Conversation

enochtangg
Copy link
Member

Enrich fetch_next type. By doing this, we would not run into the case wherefetch_next: bool is not provided (or set to false) and fetch_next_namespace: string is provided. Now, either the fetch_next message is provided with an optional namespace, or not at all.

@enochtangg enochtangg mentioned this pull request Dec 6, 2024
Merged
john-z-yang
john-z-yang approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@john-z-yang john-z-yang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the field numbers might need to change to make this not a breaking change, but I'm happy with this

@enochtangg enochtangg merged commit 387d2b0 into main Dec 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-z-yang john-z-yang john-z-yang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enochtangg @john-z-yang