Add trace logging support to ResponseMeta #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces trace logging functionality: - Added `enable_trace_logs` boolean field to RequestMeta - Added `trace_log` string field to ResponseMeta These changes allow clients to request trace logging for their queries and receive the trace log in the response. This feature will help with debugging and performance analysis of EAP API.
volokluev
reviewed
Oct 25, 2024
Removed `enable_trace_logs` boolean field from RequestMeta in request_common.proto
nachivrn
changed the title
kylemumma
approved these changes
Oct 25, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces trace logging functionality:
trace_logstring field to ResponseMetaThese changes allow clients to request trace logging for their queries and receive the clickhouse trace logs in the response. This feature will help with debugging and performance analysis of EAP API.