Skip to content

Commit

Permalink
Merge pull request #25 from getsentry/volo/eap/string_tags
Browse files Browse the repository at this point in the history
Add a type argument to the tags endpoint
Rename according to EAP terminology
Add trace_item_name to request payload (in the current case it's eap_spans)
Add endpoint for attrivute values given specific key
  • Loading branch information
volokluev authored Sep 12, 2024
2 parents 6983dd6 + 7311973 commit caf61b3
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 9 deletions.
28 changes: 19 additions & 9 deletions proto/sentry_protos/snuba/v1alpha/endpoint_tags_list.proto
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,34 @@ syntax = "proto3";
package sentry_protos.snuba.v1alpha;

import "sentry_protos/snuba/v1alpha/request_common.proto";
import "sentry_protos/snuba/v1alpha/trace_item_attribute.proto";

//A request for "which tags are available for these projects between these dates" - used for things like autocompletion
message TagsListRequest {
message TraceItemAttributesRequest {
RequestMeta meta = 1;
uint32 limit = 2;
uint32 offset = 3;
AttributeKey.Type type = 5;
}

message TagsListResponse {
enum Type {
TYPE_UNSPECIFIED = 0;
TYPE_STRING = 1;
TYPE_NUMBER = 2;
}

message TraceItemAttributesResponse {
message Tag {
string name = 1;
Type type = 2;
AttributeKey.Type type = 2;
}
repeated Tag tags = 1;
}

message AttributeValuesRequest {
RequestMeta meta = 1;
string name = 3;
// a substring of the value being searched,
// only strict substring supported, no regex
string value_substring_match = 4;
uint32 limit = 5;
uint32 offset = 6;
}

message AttributeValuesResponse {
repeated string values = 1;
}
6 changes: 6 additions & 0 deletions proto/sentry_protos/snuba/v1alpha/request_common.proto
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,10 @@ message RequestMeta {
repeated uint64 project_ids = 4;
google.protobuf.Timestamp start_timestamp = 5;
google.protobuf.Timestamp end_timestamp = 6;
TraceItemName trace_item_name = 7;
}

enum TraceItemName {
TRACE_ITEM_NAME_UNSPECIFIED = 0;
TRACE_ITEM_NAME_EAP_SPANS = 1;
}

0 comments on commit caf61b3

Please sign in to comment.