Auto detect latest GDK and Windows SDK #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1124 +/- ##
==========================================
- Coverage 82.71% 82.67% -0.04%
==========================================
Files 53 53
Lines 7930 7930
Branches 1240 1240
==========================================
- Hits 6559 6556 -3
- Misses 1261 1262 +1
- Partials 110 112 +2 |
supervacuus
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Looks great, only minor things.
I wondered if removing any explicit settings regarding the Windows SDK wouldn't lead to the same outcome (i.e., CMake will select the latest Windows SDK installed by default).
Then, we would only have the GDK detection code. However, since we need the SDK paths anyway, it is okay to couple it with the version detection.
supervacuus
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the CMake configuration to automatically detect the GDK version and WindowsSDK. This method ensures the selection of the latest installed version of the SDK. Consequently, the minimum required CMake version has been increased to 3.18 to utilize the list compare behavior.