-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add traces_sampler
#1108
base: master
Are you sure you want to change the base?
feat: add traces_sampler
#1108
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1108 +/- ##
==========================================
- Coverage 82.58% 82.42% -0.16%
==========================================
Files 53 54 +1
Lines 7896 7921 +25
Branches 1234 1237 +3
==========================================
+ Hits 6521 6529 +8
- Misses 1265 1281 +16
- Partials 110 111 +1 |
|
||
typedef struct sentry_sampling_context_s { | ||
sentry_transaction_context_t *transaction_context; | ||
void *custom_sampling_context; // TODO what type should this be? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to provide something similar to the cocoa SDK, or is it up to the users to define what type and how they'll use it in the tracesSampler callback?
e.g.
typedef struct {
char *key;
void *value;
} custom_sampling_context_entry_t;
typedef struct {
custom_sampling_context_entry_t *entries;
size_t entry_count;
} custom_sampling_context_t;
Fixes #864
sentry_traces_sampler_function
typedef (like theon_crash
andbefore_send
onessamplingContext