Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add traces_sampler #1108

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JoshuaMoelans
Copy link
Member

@JoshuaMoelans JoshuaMoelans commented Dec 20, 2024

Fixes #864

Copy link

github-actions bot commented Dec 20, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7344f8a

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.

Project coverage is 82.42%. Comparing base (b24b30c) to head (7344f8a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1108      +/-   ##
==========================================
- Coverage   82.58%   82.42%   -0.16%     
==========================================
  Files          53       54       +1     
  Lines        7896     7921      +25     
  Branches     1234     1237       +3     
==========================================
+ Hits         6521     6529       +8     
- Misses       1265     1281      +16     
- Partials      110      111       +1     


typedef struct sentry_sampling_context_s {
sentry_transaction_context_t *transaction_context;
void *custom_sampling_context; // TODO what type should this be?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to provide something similar to the cocoa SDK, or is it up to the users to define what type and how they'll use it in the tracesSampler callback?

e.g.

typedef struct {
    char *key;
    void *value;
} custom_sampling_context_entry_t;

typedef struct {
    custom_sampling_context_entry_t *entries;
    size_t entry_count;
} custom_sampling_context_t;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tracesSampler
1 participant