Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tracesSampler #864

Open
kahest opened this issue Jul 18, 2023 · 1 comment · May be fixed by #1108
Open

Support tracesSampler #864

kahest opened this issue Jul 18, 2023 · 1 comment · May be fixed by #1108
Assignees
@JoshuaMoelans
Labels
area: api enhancement New feature or request Platform: Native Product Area: SDKs - Native SDK parity Behavior that other SDKs provide and we are missing or implement differently

Comments

@kahest
Copy link
Member

kahest commented Jul 18, 2023

Add support for tracesSampler.

Relevant docs:
@kahest kahest added enhancement New feature or request area: api SDK parity Behavior that other SDKs provide and we are missing or implement differently Waiting for: Product Owner Product Area: SDKs - Native labels Jul 18, 2023
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Jul 18, 2023
@markushi
Copy link
Member

After some more discussion both tracesSampler and beforeSendTransaction should be low effort. Compared to on_crash they are not backend-specific and should be straightforward to implement.

Implementation detail: Let's keep in mind that resetting the tracesSampler should restore the original behaviour.

@supervacuus supervacuus self-assigned this Aug 4, 2023
@ashwoods ashwoods moved this from Needs Discussion to Todo in Mobile & Cross Platform SDK Sep 27, 2023
@tustanivsky tustanivsky mentioned this issue Oct 28, 2024
Merged
@supervacuus supervacuus removed their assignment Nov 18, 2024
@supervacuus supervacuus moved this from Todo to Backlog in Mobile & Cross Platform SDK Nov 18, 2024
@JoshuaMoelans JoshuaMoelans self-assigned this Dec 19, 2024
@JoshuaMoelans JoshuaMoelans linked a pull request Dec 20, 2024 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaMoelans JoshuaMoelans

Labels
area: api enhancement New feature or request Platform: Native Product Area: SDKs - Native SDK parity Behavior that other SDKs provide and we are missing or implement differently
Projects
GitHub Issues with 👀
Status: Waiting for: Product Owner
Mobile & Cross Platform SDK
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add traces_sampler getsentry/sentry-native
5 participants
@supervacuus @markushi @kahest @hubertdeng123 @JoshuaMoelans