Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Export common shims for server and edge nextjs modules #9806

Closed

Conversation

curiousercreative
Copy link

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Resolves #9796

Export common shims (BrowserTracing, Feedback, Replay) to improve DX by:
- logging error when server/edge SDK inits invoke client only modules
- avoiding compilation warnings for uninvoked client only configuration

Fixes getsentryGH-9796
@curiousercreative curiousercreative changed the title export common shims for server and edge nextjs modules feat(nextjs): Export common shims for server and edge nextjs modules Dec 12, 2023
@curiousercreative
Copy link
Author

Hmm, I doubt these build failures are related to the PR.

@mydea
Copy link
Member

mydea commented Apr 17, 2024

Hello, we are currently doing some spring cleaning! A lot of this surrounding integrations has changed in v8, so I am going to close this as it should no longer be needed. Thank you for your contribution, still!

@mydea mydea closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempted import error: 'Replay' is not exported from '@sentry/nextjs' (imported as 'Sentry').
2 participants