fix(node): Fix tRPC middleware typing #9540
Merged
+39
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Nov 13, 2023
| captureError(e); | ||
| } | ||
| } | ||
| let maybePromiseResult; |
There was a problem hiding this comment.
not directly related and nothing to do, but I feel like we've written this or very similar code a lot of times by now, maybe we can find a way to extract this into some util function that we can reuse 🤔
There was a problem hiding this comment.
Yeah agreed. It's like a promise aware try catch. Would definitely make sense to extract!
mydea
reviewed
Nov 13, 2023
| @@ -326,7 +327,7 @@ interface SentryTrpcMiddlewareOptions { | |||
|
|
|||
| interface TrpcMiddlewareArguments<T> { | |||
| path: string; | |||
| type: 'query' | 'mutation' | 'subscription'; | |||
| type: string; | |||
There was a problem hiding this comment.
Are we broading this on purpose here (just checking)
There was a problem hiding this comment.
Yes, we are not depending on any of the direct strings here (just dumping what's in type onto the event) and I figured that if trpc adds more types we will break typing again.
mydea
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9536
The issue was that the middleware returned a function that returned
Promise<Promise<T>>instead ofPromise<T>. To fix this we take care not to modify the return value at all and just return T.We could have also casted to
anyI think but this is probably cleaner.