feat(svelte)!: Disable component update tracking by default #15265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
s1gr1d
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a behaviour-breaking change to the Svelte SDK's component tracking feature: Due to a change in the lifecycle of Svelte components in Svelte 5 (using Rune mode), our SDK can no longer leverage the
(before|after)Updatehooks to track component update spans.In v8, we guarded this feature but didn't change the default behaviour via #15262.
For v9, I propose we disable update tracking by default, for the reasons outlined in #15259 (comment). (TLDR is: it would take significant effort to make this work for Svelte 5 Rune mode for a feature that's very rarely used). We can revisit this of course if we decide to emphasize component spans in the product.
ref #15259